D9100: KUriFilter: simplify data structures, fix memory leak

David Faure noreply at phabricator.kde.org
Sat Dec 2 15:06:29 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> emateli wrote in kurifilter.cpp:597
> Perhaps this can be merged with the if statement above.

It can, but I would certainly find it much less readable.
The heart of the method is to call filterUri.
The first if() is "should I call it?"
The nested if() is "did it work?"
A single if statement mixing both, would certainly make this harder to read.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9100

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: emateli, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/871f24f5/attachment.html>


More information about the Kde-frameworks-devel mailing list