D8366: Factoring out lists of url data within KFilePlacesModelTest

David Faure noreply at phabricator.kde.org
Sat Dec 2 09:43:25 UTC 2017


dfaure added inline comments.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:966
>      QTest::newRow("Places - Trash") << m_places->index(2, 0)
> -                                   << QStringLiteral("user-trash-full");
> +                                   << QStringLiteral("user-trash");
>      QTest::newRow("Remote - Network") << m_places->index(3, 0)

Why this change?
It created a regression in the CI.
Please debug fully. If this depends on your real-user's trash being full or not, then something's broken ;)  QStandardPaths' test mode should make it look in a different config dir than ~/.config (where trashrc stores this information).

http://ci-logs.kde.flaska.net/0b/0bc40d7c8b71af2c3861f5b39a4ebee91b046371/rebuilddep/rebuilddep-kf5-qt57-clang-el7/27e1666/shell_output.log

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8366

To: franckarrecot, renatoo, ervin, mlaurent
Cc: dfaure, anthonyfieroni, ervin, ngraham, mlaurent, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/a7db9381/attachment.html>


More information about the Kde-frameworks-devel mailing list