D9100: KUriFilter: simplify data structures, fix memory leak

David Faure noreply at phabricator.kde.org
Sat Dec 2 09:37:00 UTC 2017


dfaure created this revision.
dfaure added reviewers: apol, davidedmundson, arichardson, bshah.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This code had a QHash and a separate ordered list of names in order
  to use plugins in the right order. It's much simpler to just have a
  vector of plugins instead. Also, this fixes a memory leak when multiple
  plugins are found with the same name (e.g. one from /usr and one from
  my custom prefix, although the right fix for this particular
  issue is to load only one of them).

TEST PLAN
  kurifilter tests still pass

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9100

AFFECTED FILES
  src/widgets/kurifilter.cpp
  src/widgets/kurifilter.h

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171202/11aba1f4/attachment.html>


More information about the Kde-frameworks-devel mailing list