D9028: [UDisks DeviceBackend] Slightly optimize

David Edmundson noreply at phabricator.kde.org
Fri Dec 1 10:23:26 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in udisksdevicebackend.cpp:67
> Similar code in different place had a comment
> 
>   // Delay connecting to DBus signals to avoid the related time penalty
>   // in hot paths such as predicate matching

Never trust existing code.

You're not going to get to process DBus events until we hit the event queue anyway.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D9028

To: broulik, #frameworks, davidedmundson
Cc: apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171201/a162f840/attachment.html>


More information about the Kde-frameworks-devel mailing list