Review Request 121838: Fix KCoreConfigSkeleton when toggling a value with saves in between

[Albert Astals Cid]

> On gen. 6, 2015, 11:55 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 5
> > <https://git.reviewboard.kde.org/r/121838/diff/2/?file=338706#file338706line5>
> >
> >     Unrelated. And why?

Because not all of us are bleeding edge that have everything up to date and requiring ecm 1.6 here is not needed at all so i have to revert it so i can compile without having to install something that is unneeded.

And yes, it being part of the diff was a mistake on my side, it hasn't been commited.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121838/#review73316
-----------------------------------------------------------


On gen. 6, 2015, 11:55 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121838/
> -----------------------------------------------------------
> 
> (Updated gen. 6, 2015, 11:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> We need to refresh mLoadedValue after a save, otherwise the value is stale.
> 
> I'm doing this by resetting mLoadedValue to mReference in all the ::writeConfig.
> 
> I've also refactored the tests so they can be run independently now just fine.
> 
> 
> Diffs
> -----
> 
>   autotests/kconfigskeletontest.cpp f401b9f 
>   src/core/kcoreconfigskeleton.h f8313d1 
>   src/core/kcoreconfigskeleton.cpp e4255a6 
>   CMakeLists.txt 205c38b 
>   autotests/kconfigskeletontest.h c54c7b0 
> 
> Diff: https://git.reviewboard.kde.org/r/121838/diff/
> 
> 
> Testing
> -------
> 
> My tests now pass.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150106/0b4b62e0/attachment-0001.html>