Review Request 122705: Make KRatingWidget cope with devicePixelRatio

David Edmundson david at davidedmundson.co.uk
Tue Feb 24 10:57:23 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122705/
-----------------------------------------------------------

(Updated Feb. 24, 2015, 10:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
-------

All geometry calculations should be done with
image.size() / image.devicePixelRatio()


Diffs
-----

  src/kratingpainter.cpp 0bded43 
  src/kratingwidget.cpp 09cd28f 
  tests/kratingwidgettest.cpp 5465bce 

Diff: https://git.reviewboard.kde.org/r/122705/diff/


Testing
-------

Ran KRatingWidget with high DPI pixmaps. All icons now fit properly.

Ran gwenview with Qt::AA_UseHighDpiPixmaps and QT_DEVICE_PIXEL_RATIO=2


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150224/b97fe4c6/attachment.html>


More information about the Kde-frameworks-devel mailing list