Review Request 122453: Improve KPeople documentation, in order to become a Framework

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 11 12:11:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122453/
-----------------------------------------------------------

(Updated Feb. 11, 2015, 1:11 p.m.)


Review request for KDE Frameworks, KDEPIM and Telepathy.


Changes
-------

Addressed mck comments. Thanks!


Repository: libkpeople


Description
-------

Adds a README.md and a metainfo.yaml.
It also documents some classes and methods that didn't have any documentation.


Diffs (updated)
-----

  src/widgets/CMakeLists.txt bd2cd7e 
  src/widgets/mergedialog.h 305d07b 
  src/widgets/persondetailsview.h 0769d51 
  src/persondata.h 0fab902 
  src/personsmodel.h 32dc1f5 
  metainfo.yaml PRE-CREATION 
  src/CMakeLists.txt 7e01976 
  src/duplicatesfinder_p.h 05f0063 
  CMakeLists.txt 00177f3 
  README.md PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/122453/diff/


Testing
-------

Unit tests still pass ;).


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150211/18a0775f/attachment.html>


More information about the Kde-frameworks-devel mailing list