Review Request 122438: Notiy config leak fix try 2

Martin Klapetek martin.klapetek at gmail.com
Thu Feb 5 10:20:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122438/#review75460
-----------------------------------------------------------

Ship it!


Thank you!

- Martin Klapetek


On Feb. 5, 2015, 10:43 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122438/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 10:43 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> Similar to review 122396.
> 
> Well... though knotifyconfig is not installed but ABI checker seems not happy with it. So let's just use the crappy knotifyconfig for now.
> 
> 
> Diffs
> -----
> 
>   src/notifybytaskbar.cpp b52e180 
>   src/knotificationmanager.cpp 3cf637c 
>   src/knotificationplugin.h 3438e7d 
>   src/notifybypopup.h a605a77 
>   src/notifybypopup.cpp 2f08146 
>   src/CMakeLists.txt 3e5821a 
> 
> Diff: https://git.reviewboard.kde.org/r/122438/diff/
> 
> 
> Testing
> -------
> 
> works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150205/9e6a1576/attachment.html>


More information about the Kde-frameworks-devel mailing list