Review Request 120887: add custom icons to KNotification

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120887/#review69418
-----------------------------------------------------------

Ship it!


Some minor comments, looking good!


src/knotification.h
<https://git.reviewboard.kde.org/r/120887/#comment48517>

    Maybe iconName ? To me setIcon implies it accepts a QIcon(), how is this handled in other places?



src/notifybypopup.cpp
<https://git.reviewboard.kde.org/r/120887/#comment48520>

    *override


- Kai Uwe Broulik


On Okt. 29, 2014, 11:27 vorm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120887/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2014, 11:27 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> There are some cases in which applications need a custom icon for a particular notification, and used to work around sending the pixmap of the icon instead (of which you don't know if will end up the right size)
> 
> this adds an icon property to knotification, if none set, the one set in the notifyrc is used as before
> 
> 
> Diffs
> -----
> 
>   src/knotification.cpp 0ea13cb 
>   src/notifybypopup.cpp c7add40 
>   src/knotification.h 456e84b 
> 
> Diff: https://git.reviewboard.kde.org/r/120887/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141029/964b74fa/attachment-0001.html>