Review Request 118768: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118768/
-----------------------------------------------------------

(Updated June 21, 2014, 3:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Build System, Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
-------

ECMAddTests: make NAME_PREFIX only apply to the test, not the target

David Faure and Patrick Spendrin have convinced me that NAME_PREFIX
should be informational only, and not be used to prevent clashes, since
it makes things confusing when you run tests manually.


Diffs
-----

  modules/ECMAddTests.cmake 6cc20b65e25df02be6a91ac6004142d6b0f9e307 

Diff: https://git.reviewboard.kde.org/r/118768/diff/


Testing
-------

Built and tested frameworks. Some need patching up (kconfig and kio in particular). I think the safest thing is to remove the use of NAME_PREFIX from those, so that people don't have to update ECM in order to build them.

Also, I should write some unit tests...


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140621/a200a517/attachment.html>