Review Request 119464: port ToolButton to QtControls

Marco Martin notmart at gmail.com
Mon Jul 28 15:50:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119464/
-----------------------------------------------------------

(Updated July 28, 2014, 3:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

this ports ToolButton.
It's a different style than Button since it's way more complicated.

The ugly thing here is that QtControls ToolButton doesn't have a flat property, it should probably be upstreamed, at least for compatibility with the qwidgets ToolButton


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/styles/ComboBoxStyle.qml 20caef6 
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml 6dcbf7b 
  src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml PRE-CREATION 
  src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml d92a662 

Diff: https://git.reviewboard.kde.org/r/119464/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140728/b944e805/attachment.html>


More information about the Kde-frameworks-devel mailing list