OSX/MacPorts KDE CI System: Installs not into configured CMAKE_INSTALL_BUNDLEDIR on OSX - specifically for frameworks kauth & kjsembed

[David Faure]

On Saturday 05 July 2014 11:30:57 Marko Käning wrote:
> There are 6 app packages to be found on OSX which are NOT in the configured
> bundle dir.
> 
> This is understandable for libexec/kf5/kconfig_compiler_kf5.app since it was
> specifically configured to land in there.
>
> Probably also all other app packages below libexec shall indeed go there,

Yes, I'm not sure what's the problem you're seeing with libexec. It's used on 
purpose for binaries that are called by the library, rather than by the user.

> but:
> 
>   1) Why isn't kauth putting its kauth-policy-gen.app into libexec/kf5/,
> like all the others?

I don't mind this being changed.
I think this is enough to fix it, since the location of the binary is later 
extracted from the cmake target:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 49d65b3..7faffb3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -30,7 +30,7 @@ ecm_setup_version(${KF5_VERSION} VARIABLE_PREFIX KAUTH
 
 find_package(KF5CoreAddons ${KF5_DEP_VERSION} REQUIRED)
 
-set(KAUTH_HELPER_INSTALL_DIR "${LIBEXEC_INSTALL_DIR}/kauth")
+set(KAUTH_HELPER_INSTALL_DIR "${LIBEXEC_INSTALL_DIR}/kf5/kauth")
 
 if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
     ecm_install_po_files_as_qm(po)

Aleix, can you review?

>   2) Shall kjsconsole.app really live below /bin/?

Because it's a user-facing command-line tool, not an executable launched 
internally by the application.

> Would be nice to get this fixed in 5.0.0.

Definitely not going to happen.
We can move the location of a libexec binary for 5.1, no problem there.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5