Review Request 119058: add a test case for KIconLoader::addAppDir()

Marco Martin notmart at gmail.com
Tue Jul 1 18:28:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119058/
-----------------------------------------------------------

(Updated July 1, 2014, 6:28 p.m.)


Review request for KDE Frameworks.


Changes
-------

* add different test cases where only addAppDir, only reconfigure or both are used
* add resolutions of icons specific of an application


Repository: kiconthemes


Description
-------

when the theme is not complete, KIconLoader::addAppDir may break the fallback to the default themeof icons to the default theme.
this test case shhows the breakage.
commenting out addAppDir() makes the test pass.


Diffs (updated)
-----

  autotests/CMakeLists.txt 798509d 
  autotests/breeze.theme PRE-CREATION 
  autotests/kiconloader_unittest.cpp d4ec842 
  autotests/resources.qrc 33c2510 

Diff: https://git.reviewboard.kde.org/r/119058/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140701/c12f6e3c/attachment.html>


More information about the Kde-frameworks-devel mailing list