Review Request 112900: Prepare KDNSSD for moving

David Edmundson david at davidedmundson.co.uk
Wed Sep 25 10:43:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112900/#review40739
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 24, 2013, 11:14 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112900/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 11:14 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Prepares the module to be moved to its own tier.
> 
> There's a rather uncommon case with this module because there's a dependency against KConfig, but it only applies to when it's compiled with the mdnsd backend (only when there's no Avahi but mDns instead). I guess this makes it tier 2, but I'm not all that sure about that.
> 
> 
> Diffs
> -----
> 
>   dnssd/CMakeLists.txt a2dd8e6 
>   dnssd/KDNSSDConfig.cmake.in PRE-CREATION 
>   dnssd/src/CMakeLists.txt 47587af 
>   dnssd/src/avahi-publicservice.cpp 119c5a8 
>   dnssd/src/mdnsd-publicservice.cpp 2a775fa 
>   dnssd/src/servicemodel.cpp 348db57 
> 
> Diff: http://git.reviewboard.kde.org/r/112900/diff/
> 
> 
> Testing
> -------
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130925/e6cce1d9/attachment.html>


More information about the Kde-frameworks-devel mailing list