Review Request 112281: Allow setting a custom highligher on the spell check decorator

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112281/#review39051
-----------------------------------------------------------



tier1/sonnet/src/ui/spellcheckdecorator.h
<http://git.reviewboard.kde.org/r/112281/#comment28797>

    Missing class docu



tier1/sonnet/src/ui/spellcheckdecorator.h
<http://git.reviewboard.kde.org/r/112281/#comment28796>

    Missing documentation (in particular about the ownership being transferred to the decorator) .... hmm, do we really want that, btw? I thought the highlighter was also going to be used elsewhere?
    [I'm lacking context a little bit, for a full understanding]



tier1/sonnet/src/ui/spellcheckdecorator.cpp
<http://git.reviewboard.kde.org/r/112281/#comment28795>

    missing Q_UNUSED(textBlock);
    Don't you get a compiler warning here?


- David Faure


On Aug. 27, 2013, 9:21 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112281/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2013, 9:21 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Allow setting a custom highlighter on the spell check decorator
> 
> --
> 
> This is needed in order to use this code from inside KTextEdit which allows setting a custom highlighter. 
> This will also be useful for anyone wanting to subclass Sonnet::Highlighter on a QTextEdit.
> 
> 
> Diffs
> -----
> 
>   tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d 
>   tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 
> 
> Diff: http://git.reviewboard.kde.org/r/112281/diff/
> 
> 
> Testing
> -------
> 
> None - my KF5 setup has no dictionaries installed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130901/5a1bcf18/attachment-0001.html>