Review Request 111298: Add a URL handler for help:/// urls
David Faure
faure at kde.org
Mon Jul 1 09:07:15 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35340
-----------------------------------------------------------
Cool. No testing, though?
staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25896>
const QUrl &url
staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25897>
Can move inside the if(), not used otherwise.
- David Faure
On June 28, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 5:14 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
>
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
>
>
> Diffs
> -----
>
> staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7
>
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130701/8ada0dff/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list