<div dir="ltr"><div>Hi Ralf,</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">ktoblzcheck help screen shows these error conditions<br>
<br>
1: Validation algorithm is unknown/unimplemented<br>
2: Account and bank do not match<br>
3: No bank with given bank-id found<br>
<br>
which are not checked by the currently present "invalid" test checks.<br>
<br>
The present 'ktoblzcheck_invalid' checks only result (2) for german <br>
databases:<br>
<br>
7: Bank: 'Hamburger Sparkasse' at 'Hamburg <br>
' (20050550)<br>
7: Account: 1262693333<br>
7: Result is: (2) ERROR: account and bank do not match<br>
<br>
which should be extended to cover all error conditions and languages.<br></blockquote><div><br></div><div>Yeah, I agree with you. Although, since there are no validation algorithms for NL and CH checkers,</div><div>only two can be implemented for them.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>but how to specify another language without using the --file parameter.<br>
<br>
A possibility would be to add a <country-code> option e.g.<br>
<br>
ktoblzcheck [--returncode] [--file=datafile] [<country-code>] <bank-id> <br>
<account-id><br>
<br>
to run<br>
<br>
ktoblzcheck de 20050550 1262693334<br>
<br>
or<br>
<br>
ktoblzcheck nl "ABNA" "0417164300</div></blockquote><div><br></div><div>I have added this feature, just forgot to update the usage message. <br></div><div>See: <a href="https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/ci/39e3d785ddbd18d9f6db52bd9b26ea5a897dee8a/">https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/ci/39e3d785ddbd18d9f6db52bd9b26ea5a897dee8a/</a></div><div><br></div><div>It can be run as:</div><div>
ktoblzcheck DE 20050550 1262693334</div><div>or</div><div>
ktoblzcheck 20050550 1262693334(for Germany)</div><div>ktoblzcheck NL ABNA 0417164300 (for Netherlands)</div><div>ktoblzcheck CH 00761 011623852957(for Switzerland)</div><div><br></div><div>I will update the message and add support for lowercase country code input.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>PS: Good job so far</div></blockquote><div><br></div><div>Thanks :)</div><div><br></div><div>Prasun<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, 11 Aug 2020 at 18:34, Ralf Habacker <<a href="mailto:ralf.habacker@freenet.de">ralf.habacker@freenet.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 08.08.20 um 05:28 schrieb Prasun Kumar:<br>
Hi Prasun,<br>
<br>
> The rest of the work from the second phase has been completed. The databases<br>
> for the additional countries have been incorporated in the library. <br>
> Please take a look and suggest any necessary changes.<br>
<br>
I took a look<br>
<br>
> Commits: <br>
> <a href="https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/commit_browser" rel="noreferrer" target="_blank">https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/commit_browser</a><br>
> Blog post: <a href="https://prasunka.github.io/posts/gsoc2020-phase-2" rel="noreferrer" target="_blank">https://prasunka.github.io/posts/gsoc2020-phase-2</a><br>
<br>
ktoblzcheck help screen shows these error conditions<br>
<br>
1: Validation algorithm is unknown/unimplemented<br>
2: Account and bank do not match<br>
3: No bank with given bank-id found<br>
<br>
which are not checked by the currently present "invalid" test checks.<br>
<br>
The present 'ktoblzcheck_invalid' checks only result (2) for german <br>
databases:<br>
<br>
7: Bank: 'Hamburger Sparkasse' at 'Hamburg <br>
' (20050550)<br>
7: Account: 1262693333<br>
7: Result is: (2) ERROR: account and bank do not match<br>
<br>
which should be extended to cover all error conditions and languages.<br>
<br>
e.g.<br>
add_test(NAME ktoblzcheck_invalid1 ...)<br>
add_test(NAME ktoblzcheck_invalid2 ...)<br>
add_test(NAME ktoblzcheck_invalid3 ...)<br>
<br>
add_test(NAME ktoblzcheck_nl_invalid1 ...)<br>
add_test(NAME ktoblzcheck_nl_invalid2 ...)<br>
add_test(NAME ktoblzcheck_nl_invalid3 ...)<br>
<br>
add_test(NAME ktoblzcheck_ch_invalid1 ...)<br>
add_test(NAME ktoblzcheck_ch_invalid2 ...)<br>
add_test(NAME ktoblzcheck_ch_invalid3 ...)<br>
<br>
The checks for german database could also be renamed to use the common <br>
test name style:<br>
<br>
add_test(NAME ktoblzcheck_de_invalid1 ...)<br>
add_test(NAME ktoblzcheck_de_invalid2 ...)<br>
add_test(NAME ktoblzcheck_de_invalid3 ...)<br>
<br>
to match the language.<br>
<br>
ktoblzcheck is designed to use database files from default location<br>
<br>
$ ktoblzcheck --help<br>
Usage:<br>
ktoblzcheck [--returncode] [--file=datafile] <bank-id> <account-id><br>
<br>
<br>
but how to specify another language without using the --file parameter.<br>
<br>
A possibility would be to add a <country-code> option e.g.<br>
<br>
ktoblzcheck [--returncode] [--file=datafile] [<country-code>] <bank-id> <br>
<account-id><br>
<br>
to run<br>
<br>
ktoblzcheck de 20050550 1262693334<br>
<br>
or<br>
<br>
ktoblzcheck nl "ABNA" "0417164300"<br>
<br>
<br>
PS: Good job so far<br>
<br>
Regards<br>
Ralf<br>
<br>
</blockquote></div>