<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Am 20.06.20 um 11:00 schrieb Prasun
Kumar:<br>
</div>
<blockquote type="cite"
cite="mid:CAM9DqsJ9Qc3pN9UmzJk9t2v3MrC1xdiUrUzfme7POiNzkm5CiQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span
class="gmail-im">> Also, there are many methods which
deal solely with textfile reading</span><br>
<span class="gmail-im">
> such as dataValidStartDate(), dataValidEndDate(),
isDataValidForDate(),</span><br>
<span class="gmail-im">
> find_closest_datafile to name a few.</span><br>
<span class="gmail-im">
</span><br>
<span class="gmail-im"></span>
> bool isDataValidForDate(std::time_t date) const;<br>
><br>
> /** Returns true if a bankdata file valid for the given
date is<br>
> * available, otherwise false.<br>
> *<br>
> * Whether this file has already been loaded has to be
queried<br>
> * separately through isDataValidForDate().<br>
> *<br>
> * This function was introduced in ktoblzcheck-1.15.<br>
*/<br>
This and the other methods are part of the public api and
should not be<br>
<div>
removed as clients may depends on them.<span
class="gmail-im"><br>
</span></div>
</blockquote>
<div><br>
</div>
<div>If these methods are to exist, should the support of
bankdata "text" files be kept enabled in the code? <br>
</div>
</div>
</blockquote>
no<br>
<blockquote type="cite"
cite="mid:CAM9DqsJ9Qc3pN9UmzJk9t2v3MrC1xdiUrUzfme7POiNzkm5CiQ@mail.gmail.com">
<div dir="ltr">
<div>Specifically, should the constructor retain the call to
init_datefile_list() even while reading through a SQLite DB?</div>
</div>
</blockquote>
<p>no</p>
<p>To give developer a hint that those function should not be used
anymore, a cpp macro DEPRECATED should be added to
ktoblzcheck.h.in and iban.h if required e.g. something like:<br>
</p>
<pre class="lang-cpp prettyprint prettyprinted" style=""><code><span class="com">#if defined(__GNUC__) || defined(__clang__)</span><span class="pln">
</span><span class="com">#define</span><span class="pln"> DEPRECATED __attribute__</span><span class="pun">((</span><span class="pln">deprecated</span><span class="pun">))</span><span class="pln">
</span><span class="com">#elif</span><span class="pln"> defined</span><span class="pun">(</span><span class="pln">_MSC_VER</span><span class="pun">)</span><span class="pln">
</span><span class="com">#define</span><span class="pln"> DEPRECATED __declspec</span><span class="pun">(</span><span class="pln">deprecated</span><span class="pun">)</span><span class="pln">
</span><span class="com">#else</span><span class="pln">
</span><span class="com">#pragma</span><span class="pln"> message</span><span class="pun">(</span><span class="str">"WARNING: You need to implement DEPRECATED for this compiler"</span><span class="pun">)</span><span class="pln">
</span><span class="com">#define</span><span class="pln"> DEPRECATED
</span><span class="com">#endif</span><span class="pln">
</span><span class="com">//...</span><span class="pln">
</span><span class="com">//don't use me any more</span><span class="pln">
DEPRECATED </span></code><code><span class="pln"><span class="gmail-im"></span>bool isDataValidForDate(std::time_t date) const;
Regards
Ralf
</span><span class="pun"></span></code></pre>
<blockquote type="cite"
cite="mid:CAM9DqsJ9Qc3pN9UmzJk9t2v3MrC1xdiUrUzfme7POiNzkm5CiQ@mail.gmail.com">
<div dir="ltr"><br>
<span class="gmail-im"></span>
<div><span class="gmail-im"></span></div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, 14 Jun 2020 at 01:35,
Ralf Habacker <<a href="mailto:ralf.habacker@freenet.de"
moz-do-not-send="true">ralf.habacker@freenet.de</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am
13.06.20 um 06:52 schrieb Prasun Kumar:<br>
> Hi mentors,<br>
> I have tested the SQLite database to implement<br>
> AccountNumberCheck::findbank() and it worked
successfully. Now I'm<br>
> ready to change the present code.<br>
> So how should I make these commits? Should I replace the
current code<br>
> by commenting them out<br>
No need for that as changes are recorded in git log<br>
<br>
or should I remove them altogether?<br>
<br>
yes, see above<br>
<br>
> Also, there are many methods which deal solely with
textfile reading<br>
> such as dataValidStartDate(), dataValidEndDate(),
isDataValidForDate(),<br>
> find_closest_datafile to name a few.<br>
<br>
> bool isDataValidForDate(std::time_t date) const;<br>
><br>
> /** Returns true if a bankdata file valid for the given
date is<br>
> * available, otherwise false.<br>
> *<br>
> * Whether this file has already been loaded has to be
queried<br>
> * separately through isDataValidForDate().<br>
> *<br>
> * This function was introduced in ktoblzcheck-1.15.<br>
*/<br>
This and the other methods are part of the public api and
should not be<br>
removed as clients may depends on them.<br>
<br>
> To make the commits small, I would be making a commit for
each method<br>
> change.<br>
yes, looks good.<br>
<br>
Regards<br>
<br>
Ralf<br>
<br>
<br>
</blockquote>
</div>
</blockquote>
</body>
</html>