<br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">A few comments:<br>
<br>
<br>
- I think I mentioned the missing license issue already.<br>
<br>
- I ran astyle which formatted some code. Please update your sandbox from svn<br>
to get those changes in formatting.<br>
<br>
- Please add more description to the alkuser object. What is is good for and<br>
what's its purpose? I am not sure what the attributes should be used for, so I<br>
can't really comment on it. Same for keyusermanager. Maybe, the lack of<br>
comments is the source for all my questions below.<br>
<br></blockquote><div>ok <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
- The DTOR of AlkUser does not delete the private 'd' memory. This will result<br>
in memory leaks.<br>
<br>
- What is 'Q_String'? Please use QString as type in alkuser.cpp<br>
<br>
- The line<br>
<br>
class ALK_EXport AlkUser : public QObject<br>
<br>
in alkuser.h should read<br>
<br>
class ALK_EXPORT AlkUser : public QObject<br>
<br>
to work properly.<br>
<br></blockquote><div>thanks <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
- There is no CMakeLists.txt file which would allow to build the software.<br>
<br>
- Why is the amount attribute a QString and not an AlkValue?<br>
<div class="im"><br>
<br></div></blockquote><div>Actually i didnt included the alkvalue anywhere, for now i just wanted to input some information into the DBUS and take some ouput from the DBUS correctly, so didnt included the concept of AlkValue <br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im">
<br>
> And even i was not able to use any test over these.<br>
<br>
</div>What are you trying to accomplish? Please try to explain what you are trying<br>
to achieve with those objects. We can certainly help.<br>
<br><br></blockquote><div>For now I am trying to establish a connection with the DBUS correctly so that i can procede further<br>As I am working on the payment detection usecase the data wil have to be fed to the database by each application using the DBUS service<br>
So for now i am just focussing on creating a connection between the database and the dbus<br><br>Now i am just working on the above comments.<br>Will be back with the changes as soon as possible<br>Thank you<br>Regards,<br>
Puneet<br></div></div>