<br><br><div class="gmail_quote">On Mon, Jun 21, 2010 at 11:10 PM, Fernando Vilas <span dir="ltr"><<a href="mailto:fvilas@iname.com">fvilas@iname.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Monday, June 21, 2010 13:45:09 Thomas Baumgart wrote:<br>
> Hi all,<br>
><br>
> on Monday 21 June 2010 18:53:07 Mukesh Gupta wrote:<br>
> > Hello Friends,<br>
> ><br>
> > My first commit to for alkimia is here<br>
> > <a href="https://svn.kde.org/home/kde/trunk/playground/office/alkimia/alkdbus/Alkr" target="_blank">https://svn.kde.org/home/kde/trunk/playground/office/alkimia/alkdbus/Alkr</a><br>
</div>> > ec ord/<br>
<div class="im">> ><br>
> > It consists of alkrecord class which will handle query and register<br>
> > functions for the dbus server.Will add more functionality soon.The file<br>
> ><br>
> > :ALK_DBASE: file is the sqlie database which is initially populated with<br>
> ><br>
</div>[snip lots of useful feedback]<br>
<div class="im">><br>
><br>
> So much for now. I know, Rome wasn't built in one day, but I want to give<br>
> as much feedback as possible.<br>
<br>
</div>[snip lots more of useful feedback]<br>
<font color="#888888"></font><br></blockquote></div><br>I see you added some printf statement, probably for debug. That's a good indication that you have to add unit tests, which can provide you better on what you are doing. We cannot stress enough how important unit testing is. Some people will even add the unit tests first and the main code later, and they can tell when they are done with coding because all tests pass.<br>
<br>About the connection, one way to do it is keeping the connection open along the life of the class, checking that's it's effectively open every time you are going to use it. As Fernando said, opening and closing connections every time is very expensive.<br>
<br>I guess you have a lot to do based on this feedback. Please don't hesitate to ask if there's anything you don't quite understand or that you have doubts about.<br><br>The good things about FOSS is that people can see your code and comment it. The bad thing is that people can see your code and comment it. You are doing great and you'll fix these nuisances easily.<br>
<br>Regards,<br>Alvaro<br>