<table><tr><td style="">TallFurryMan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29821">View Revision</a></tr></table><br /><div><div><p>Excellent, thanks for this proposal! I have nothing but minor points, looks good to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29821#inline-170819">View Inline</a><span style="color: #4b4d51; font-weight: bold;">capture.cpp:1948</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #74777d">// force refocus</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KSTARS_EKOS_CAPTURE</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Capture is triggering autofocus on line 19<span class="bright">04</span>."</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KSTARS_EKOS_CAPTURE</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Capture is triggering autofocus on line 19<span class="bright">48</span>."</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">emit</span> <span style="color: #004012">checkFocus</span><span class="p">(</span><span style="color: #601200">0.1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Good spot, wouldn't <tt style="background: #ebebeb; font-size: 13px;">__LINE__</tt> solve this problem? :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29821#inline-170820">View Inline</a><span style="color: #4b4d51; font-weight: bold;">capture.cpp:1956</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    </span><span style="color: #aa4000"><span class="bright">else</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">isInSequenceFocus</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="n"><span class="bright">inSequenceFocusCounter</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">isInSequenceFocus</span> <span style="color: #aa2211">&&</span> <span class="n">inSequenceFocusCounter</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yes, there was an <tt style="background: #ebebeb; font-size: 13px;">else</tt> after a <tt style="background: #ebebeb; font-size: 13px;">if-then-return</tt>, but with big blocks of code like this, it is probably better to consider the <tt style="background: #ebebeb; font-size: 13px;">if</tt> addresses <tt style="background: #ebebeb; font-size: 13px;">isRefocus</tt>, <tt style="background: #ebebeb; font-size: 13px;">isInSequenceFocus</tt> and <tt style="background: #ebebeb; font-size: 13px;">inSequenceFocusCounter</tt> as a set of three related flags, instead of the things that happen in those blocks. So please keep the <tt style="background: #ebebeb; font-size: 13px;">else</tt> for clarity, so that others understand? (minor)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29821#inline-170821">View Inline</a><span style="color: #4b4d51; font-weight: bold;">focus.cpp:584</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">currentTemperature</span> <span style="color: #aa2211">=</span> <span class="n">focuserTemperature</span><span style="color: #aa2211">-></span><span class="n">np</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">].</span><span class="n">value</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qCDebug</span><span class="p">(</span><span class="n">KSTARS_EKOS_FOCUS</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"Setting current focuser temperature: %1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">currentTemperature</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You could use numeric precision here for your log.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29821">https://phabricator.kde.org/D29821</a></div></div><br /><div><strong>To: </strong>fsignoret, mutlaqja<br /><strong>Cc: </strong>TallFurryMan, kde-edu, narvaez, apol<br /></div>