<table><tr><td style="">astrorunner added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29325">View Revision</a></tr></table><br /><div><div><p>Hi Eric,</p>
<p>The e-mail address for my github and phabricator account are all the same. I have matched my committer and author name to match the phabricator too, but that doesn't seem to work.</p>
<p>Here the result of 'git log --format=full HEAD'</p>
<p>$ git log --format=full HEAD<br />
commit f75ee7357e1ac3cd7b7cfbf68468d8b5b36f4513 (HEAD -> new_bahtinov_attempt)<br />
Author: astrorunner <pr_molenaar@hotmail.com><br />
Commit: astrorunner <pr_molenaar@hotmail.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Fix compiler error (comparison between int and double)
Summary:
Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)
Updated copyright information
Added unit test for bahtinov focus assistent
Fix build error
Subscribers: kde-edu
Tags: #kde_edu
Differential Revision: https://phabricator.kde.org/D29364</pre></div>
<p>commit 57682009ba84871f733626a2a1e4ad96fd76fcbb<br />
Author: astrorunner <pr_molenaar@hotmail.com><br />
Commit: astrorunner <pr_molenaar@hotmail.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Added unit test for bahtinov focus assistent</pre></div>
<p>commit e60e9050eb5c15e1b58d9f8973c4448ba0c05b9e<br />
Author: astrorunner <pr_molenaar@hotmail.com><br />
Commit: astrorunner <pr_molenaar@hotmail.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Updated copyright information</pre></div>
<p>commit bb0532cab26b215219c21b7bd252ceec14bc503c<br />
Author: astrorunner <pr_molenaar@hotmail.com><br />
Commit: astrorunner <pr_molenaar@hotmail.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)</pre></div>
<p>commit 343311c4b033e90c06453b3b49caeb50b64aced3<br />
Author: astrorunner <pr_molenaar@hotmail.com><br />
Commit: astrorunner <pr_molenaar@hotmail.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Fix compiler error (comparison between int and double)</pre></div>
<p>commit <a href="https://phabricator.kde.org/R321:3d738d3a6ea07d362cdb579c74052b29ab659157" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">3d738d3a6ea07d362cdb579c74052b29ab659157</a> (kde/master, master)<br />
Author: Hy Murveit <hy-2@murveit.com><br />
Commit: Jasem Mutlaq <mutlaqja@ikarustech.com></p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Comment out a couple wordy debug log messages
Test Plan: Check that no code changed, outside of 2 fewer log lines.
Reviewers: mutlaqja, chrisrowland
Reviewed By: mutlaqja
Subscribers: kde-edu
Tags: #kde_edu
Differential Revision: https://phabricator.kde.org/D29317</pre></div>
<p>I see in the logging that I should use my full name as committer and author. I will change the git log (as described in an earlier e-mail) and then commit it again. Hopefully that will solve the issue.</p>
<p>Kind regards,</p>
<p>Patrick</p>
<hr class="remarkup-hr" />
<p>Van: Eric Dejouhanet <noreply@phabricator.kde.org><br />
Verzonden: maandag 4 mei 2020 10:59<br />
Aan: pr_molenaar@hotmail.com <pr_molenaar@hotmail.com>; jarno.paananen@gmail.com <jarno.paananen@gmail.com>; luigi.toscano@tiscali.it <luigi.toscano@tiscali.it>; rlancaste@gmail.com <rlancaste@gmail.com>; akarsh.simha@kdemail.net <akarsh.simha@kdemail.net>; valentin@boettcher.cf <valentin@boettcher.cf>; mutlaqja@ikarustech.com <mutlaqja@ikarustech.com>; prasun.code@gmail.com <prasun.code@gmail.com>; zyziuk@gmail.com <zyziuk@gmail.com>; alex@navigheaza.ro <alex@navigheaza.ro>; steffen_moeller@gmx.de <steffen_moeller@gmx.de><br />
CC: kde-edu@kde.org <kde-edu@kde.org>; david.narvaez@computer.org <david.narvaez@computer.org>; aleixpol@kde.org <aleixpol@kde.org><br />
Onderwerp: <a href="https://phabricator.kde.org/D29325" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D29325</a>: Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)</p>
<p>View Revision<a href="https://phabricator.kde.org/D29325" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D29325</a><br />
TallFurryMan added a comment.</p>
<p>My initial mail was blocked for moderation, sorry for this weird reply:</p>
<p>Patrick, could you share the result of "git log HEAD" (without the patch part, only the header so we see the committer and the author) ?<br />
My KDE user is "TallFurryMan" but my profile name there is "Eric Dejouhanet". More importantly I think, my email is the same in my commits and in my profile.</p>
<p>REPOSITORY<br />
<a href="https://phabricator.kde.org/source/kstars/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">R321</a> KStars</p>
<p>BRANCH<br />
new_bahtinov_attempt (branched from master)</p>
<p>REVISION DETAIL<br />
<a href="https://phabricator.kde.org/D29325" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D29325</a></p>
<p>To: astrorunner, KStars, TallFurryMan, mutlaqja<br />
Cc: lancaster, astrorunner, mutlaqja, TallFurryMan, kde-edu, narvaez, apol</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29325">https://phabricator.kde.org/D29325</a></div></div><br /><div><strong>To: </strong>astrorunner, KStars, TallFurryMan, mutlaqja<br /><strong>Cc: </strong>lancaster, astrorunner, mutlaqja, TallFurryMan, kde-edu, narvaez, apol<br /></div>