<table><tr><td style="">astrorunner created this revision.<br />astrorunner added a reviewer: KStars.<br />Herald added a project: KDE Edu.<br />Herald added a subscriber: kde-edu.<br />astrorunner requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29325">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Implemented Bahtinov mask focus assistant, fix compiler warnings (in fpackutil.c and modcalcvizequinox.cpp)<br />
Added unit test for bahtinov focus assistent<br />
Fix compiler error (comparison between int and double)<br />
Fix compiler error after merge</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Conflicts:</li>
<li class="remarkup-list-item">kstars/fitsviewer/fitsview.cpp</li>
</ol></div></div><br /><div><strong>TEST PLAN</strong><div><p>Tested manually by installing software on Raspberry Pi and connect it to my telescope, pointing to a bright star and check if bahtinov mask is overlaying the diffraction pattern correctly.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>BRANCH</strong><div><div>bahtinov-mask-focus-process-review-comments (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29325">https://phabricator.kde.org/D29325</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>Tests/fitsviewer/CMakeLists.txt<br />
Tests/fitsviewer/bahtinov-focus.fits<br />
Tests/fitsviewer/testfitsdata.cpp<br />
Tests/fitsviewer/testfitsdata.h<br />
kstars/CMakeLists.txt<br />
kstars/ekos/focus/focus.cpp<br />
kstars/ekos/focus/focus.ui<br />
kstars/fitsviewer/fitsbahtinovdetector.cpp<br />
kstars/fitsviewer/fitsbahtinovdetector.h<br />
kstars/fitsviewer/fitscommon.h<br />
kstars/fitsviewer/fitsdata.cpp<br />
kstars/fitsviewer/fitsdata.h<br />
kstars/fitsviewer/fitsstardetector.h<br />
kstars/fitsviewer/fitsview.cpp<br />
kstars/fitsviewer/fitsviewer.cpp<br />
kstars/fitsviewer/fpackutil.c<br />
kstars/fitsviewer/hough/houghline.cpp<br />
kstars/fitsviewer/hough/houghline.h<br />
kstars/kstars.kcfg</div></div></div><br /><div><strong>To: </strong>astrorunner, KStars<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>