<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28456">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28456#inline-161889">View Inline</a><span style="color: #4b4d51; font-weight: bold;">number_sequence.js:148</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">function</span> <span style="color: #004012">won</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bonus</span><span class="p">.</span><span style="color: #004012">win</span><span class="p">.</span><span style="color: #004012">connect</span><span class="p">(</span><span style="color: #004012">nextLevel</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bonus</span><span class="p">.</span><span style="color: #004012">win</span><span class="p">.</span><span style="color: #004012">disconnect</span><span class="p">(</span><span style="color: #004012">nextLevel</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bonus</span><span class="p">.</span><span style="color: #004012">good</span><span class="p">(</span><span style="color: #766510">"flower"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">instead of changing it twice in initLevel and in won, would it be better to always connect the signal in Bonus to an internal slot and in this slot, check if mode == 1. If yes, we call Activity.nextLevel?<br />
This way, we don't play with connect/disconnect and the change is only on one place</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28456">https://phabricator.kde.org/D28456</a></div></div><br /><div><strong>To: </strong>shubhammishra, jjazeix, GCompris: Improvements<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>