<table><tr><td style="">dekumar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27583">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#626328" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#626328</a>, <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625178" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625178</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625177" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625177</a>, <a href="https://phabricator.kde.org/p/dekumar/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dekumar</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#624933" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#624933</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm wondering if we should not have the image names in the dataset too so later we can choose which images to display</p></div>
</blockquote>
<p>Can you elaborate a bit more about it? Are you talking about the images in mosaic.js file?</p></div>
</blockquote>
<p>Yes, should we allow the possibility to the creator of the dataset to specify which images he wants? May be useful later for teachers or customisation. May be too much too.<br />
<a href="https://phabricator.kde.org/p/timotheegiet/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@timotheegiet</a> <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> does it make sense?</p></div>
</blockquote>
<p>Hi,<br />
It does really make sens. We need to think about the "step after". We may have in mind, (even if we do not do it at the end) that our server should allow to customise activities. The server could allow adding sublevels then presenting the attributes to fill. The variable therefore must be self explanatory, and we may have to add comments in front of the attributes to tell what they are and how to fill them. eg: //layout: describes the way the cells are displayed, eg: "layout": [ [6,4], [12,2] ],<br />
In my case as programmer, thinking about the final user would force me to replace for example nbItems by nbOfCells which is clearer for the final user.<br />
Here as final user, for example I do not know what multipleDatasetType is neither multipleDataset2.</p></div>
</blockquote>
<p><a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> Hi, Thanks for the review. I would rename the variable with good names and add comments too as described by you.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#626328" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#626328</a>, <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625178" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625178</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625177" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625177</a>, <a href="https://phabricator.kde.org/p/dekumar/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dekumar</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#624933" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#624933</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm wondering if we should not have the image names in the dataset too so later we can choose which images to display</p></div>
</blockquote>
<p>Can you elaborate a bit more about it? Are you talking about the images in mosaic.js file?</p></div>
</blockquote>
<p>Yes, should we allow the possibility to the creator of the dataset to specify which images he wants? May be useful later for teachers or customisation. May be too much too.<br />
<a href="https://phabricator.kde.org/p/timotheegiet/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@timotheegiet</a> <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> does it make sense?</p></div>
</blockquote>
<p>Hi,<br />
It does really make sens. We need to think about the "step after". We may have in mind, (even if we do not do it at the end) that our server should allow to customise activities. The server could allow adding sublevels then presenting the attributes to fill. The variable therefore must be self explanatory, and we may have to add comments in front of the attributes to tell what they are and how to fill them. eg: //layout: describes the way the cells are displayed, eg: "layout": [ [6,4], [12,2] ],<br />
In my case as programmer, thinking about the final user would force me to replace for example nbItems by nbOfCells which is clearer for the final user.<br />
Here as final user, for example I do not know what multipleDatasetType is neither multipleDataset2.</p></div>
</blockquote>
<p>Hello <span class="phabricator-remarkup-mention-unknown">@echarurau</span>, Thanks for the review. I would rename the variables with good name and add comments too.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#626328" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#626328</a>, <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625178" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625178</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#625177" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#625177</a>, <a href="https://phabricator.kde.org/p/dekumar/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dekumar</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D27583#624933" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D27583#624933</a>, <a href="https://phabricator.kde.org/p/jjazeix/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@jjazeix</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm wondering if we should not have the image names in the dataset too so later we can choose which images to display</p></div>
</blockquote>
<p>Can you elaborate a bit more about it? Are you talking about the images in mosaic.js file?</p></div>
</blockquote>
<p>Yes, should we allow the possibility to the creator of the dataset to specify which images he wants? May be useful later for teachers or customisation. May be too much too.<br />
<a href="https://phabricator.kde.org/p/timotheegiet/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@timotheegiet</a> <a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> does it make sense?</p></div>
</blockquote>
<p>Hi,<br />
It does really make sens. We need to think about the "step after". We may have in mind, (even if we do not do it at the end) that our server should allow to customise activities. The server could allow adding sublevels then presenting the attributes to fill. The variable therefore must be self explanatory, and we may have to add comments in front of the attributes to tell what they are and how to fill them. eg: //layout: describes the way the cells are displayed, eg: "layout": [ [6,4], [12,2] ],<br />
In my case as programmer, thinking about the final user would force me to replace for example nbItems by nbOfCells which is clearer for the final user.<br />
Here as final user, for example I do not know what multipleDatasetType is neither multipleDataset2.</p></div>
</blockquote>
</div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27583#inline-158459">View Inline</a><span style="color: #4b4d51; font-weight: bold;">echarruau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">Mosaic.qml:127</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I don't understand this multipledataset1 variable. <br />
Is it related to the device layout (portrait/landscape) or to the layout targeted 'single/multiple line".</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a> Hi, It is related with the targeted layout "single/multipleLine". I have made the use the states in the code to change different property in case of both of the multiple dataset.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27583#inline-158453">View Inline</a><span style="color: #4b4d51; font-weight: bold;">echarruau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">Data.qml:24</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">"Rebuild" not rebuid. Anyway the we could have a shorter description:<br />
Items are on a single line.<br />
Items on multiple lines.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sure, I would update it.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27583">https://phabricator.kde.org/D27583</a></div></div><br /><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix, timotheegiet, echarruau<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>