<table><tr><td style="">TallFurryMan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27678">View Revision</a></tr></table><br /><div><div><p>Please don't test this on your own setup, because it may change your userdb (it doesn't right now, but will certainly).<br />
I need a way to use another database, so that options are all default.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156419">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">void</span></span><span class="bright"> </span><span class="n"><span class="bright">KStarsUiTests</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">warnTest</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q<span class="bright">WARN</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"This is a test expected to print a warning message."</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #74777d"><span class="bright">// Initialize our location</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n"><span class="bright">GeoLocation</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">g</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">KStars</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Instance</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">data</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">locationNamed</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Greenwich"</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Q<span class="bright">VERIFY</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">g</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">nullptr</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This was cheating: I used the city database, while I should have used arbitrary latitude and longitude, eventually verifying this was Greenwhich.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156421">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QEXPECT_FAIL</span><span class="p">(</span><span style="color: #766510">""</span><span class="p">,</span> <span style="color: #766510">"Initial KStars clock is set from system local time, not geolocation, and is untestable for now."</span><span class="p">,</span> <span class="n">Continue</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">clock</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">utc</span><span class="p">().</span><span class="n">toString</span><span class="p">(),</span> <span class="n">m_InitialConditions</span><span class="p">.</span><span class="n">dateTime</span><span class="p">.</span><span class="n">toString</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">There's apparently no way to *not* use the system properties when initializing KStars, due to KStarsDateTime management of UTC/localtime. This should be tested in a unitary test elsewhere.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156420">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:99</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QEXPECT_FAIL</span><span class="p">(</span><span style="color: #766510">""</span><span class="p">,</span> <span style="color: #766510">"Precision of KStars local time conversion to local time does not allow strict millisecond comparison."</span><span class="p">,</span> <span class="n">Continue</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QCOMPARE</span><span class="p">(</span><span class="n">KStars</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">clock</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">utc</span><span class="p">().</span><span class="n">toLocalTime</span><span class="p">(),</span> <span class="n">m_InitialConditions</span><span class="p">.</span><span class="n">dateTime</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I always end up with a comparison between xxx.999ms and xxx.000ms. Rounding issues somewhere on the QDateTime/KStarsDataTime chain.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156422">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:127</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QDir</span> <span class="n">writableDir</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">writableDir</span><span class="p">.</span><span class="n">mkdir</span><span class="p">(</span><span class="n">KSPaths</span><span style="color: #aa2211">::</span><span class="n">writableLocation</span><span class="p">(</span><span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">GenericDataLocation</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KCrash</span><span style="color: #aa2211">::</span><span class="n">initialize</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is currently useless.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156423">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I had to use this method in order to use multiple test classes that execute in parallel with the GUI.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156425">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kstars_ui_tests.cpp:165</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Limit execution duration</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTimer</span><span style="color: #aa2211">::</span><span class="n">singleShot</span><span class="p">(</span><span style="color: #601200">5</span><span style="color: #aa2211">*</span><span style="color: #601200">60</span><span style="color: #aa2211">*</span><span style="color: #601200">1000</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">app</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">quit</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This value hard-codes a limit to the duration of the test. I'll probably remove it and rely on another method to detect the end of the asynchronous tests. Normally QTest::qExec calls should not break out of the singleShot() call above, so this is more a safeguard against lock-up. But that safeguard would be better done with a timeout shell wrapper.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156426">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_ekos.cpp:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #74777d"><span class="bright">// We use that poor man's shared variable to hold the result of the first (creation) and second (edition) test step.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #74777d">/<span class="bright">/ The ProfileEditor is exec()'d, so test code must be made asynchronous, and QTimer::singleShot is an easy way to do that.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #74777d"><span class="bright">// We use two timers, one to run the end-user test, which eventually will close the dialog, and a second one to really close if the test step fails.</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">bool</span> <span class="n">testIsSuccessful</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">/<span class="bright">* No-op, we just use init+cleanup */</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This one might seem unrelevant, but it actually reveals that Ekos is resetting and resuming the Simulation Clock of KStars. It results in a relatively long update of all sky objects of KStars. As I have downloaded many Minor Planet elements, this can take around 30 seconds on my Core i7, which is far from negligible.</p>
<p style="padding: 0; margin: 8px;">This has the side effect of breaking all sky object coordinates fixtures, which are computed from initial conditions below in TestEkosSimulator.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156427">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_ekos_simulator.cpp:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">GeoLocation</span> <span style="color: #aa2211">*</span> <span style="color: #aa4000">const</span> <span class="n">geo</span> <span style="color: #aa2211">=</span> <span class="n">KStarsData</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">geo</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KStarsDateTime</span> <span style="color: #aa4000">const</span> <span style="color: #004012">now</span><span class="p">(</span><span class="n">KStarsData</span><span style="color: #aa2211">::</span><span class="n">Instance</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">lt</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KSNumbers</span> <span style="color: #aa4000">const</span> <span style="color: #004012">numbers</span><span class="p">(</span><span class="n">now</span><span class="p">.</span><span class="n">djd</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would expect this to use the initial conditions in KStarsUiTest, but actually Ekos resets the Simulation Clock.<br />
What is weird is that this test fixture generation is executed *after* the first Ekos startup, so lt() should provide the updated local time.<br />
Still, many sky objects are placed incorrectly in the sky and end below the horizon, even though altitude is tested.<br />
So, this must be bugged. But the test manages that with an expected failure.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156429">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_ekos_simulator.cpp:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> QTest::qWait(5000);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> KTRY_EKOS_CLICK("mountToolBoxB");</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#else</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">First, I tried to use the UI to slew to specific RA/DEC.<br />
It appears the Mount Control box is the only one to provide a way to enter numeric values.<br />
However, QML just doesn't provide you a gadget if that gadget miss the "objectName" property.</p>
<p style="padding: 0; margin: 8px;">Also that reveals that apart from the Mount Control box, only the Scheduler is able to slew with numerical values.<br />
The other way is to right-click on the sky map, which is not very numerical.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156430">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_ekos_simulator.cpp:128</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QEXPECT_FAIL</span><span class="p">(</span><span class="n">NAME</span><span class="p">.</span><span class="n">toStdString</span><span class="p">().</span><span class="n">c_str</span><span class="p">(),</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"Slew target '%1' is expected to be over the horizon during night time."</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">NAME</span><span class="p">).</span><span class="n">toStdString</span><span class="p">().</span><span class="n">c_str</span><span class="p">(),</span> <span class="n">Abort</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY</span><span class="p">(</span><span class="n">slew_result</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This block is a contrived way to bypass the notification box produced by the telescope handler...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27678#inline-156431">View Inline</a><span style="color: #4b4d51; font-weight: bold;">test_ekos_simulator.cpp:137</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVERIFY</span><span class="p">(</span><span class="n">raOut</span> <span style="color: #aa2211">!=</span> <span style="color: #aa4000">nullptr</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTRY_VERIFY_WITH_TIMEOUT</span><span class="p">(</span><span class="n">abs</span><span class="p">(</span><span class="n">clampRA</span><span class="p">(</span><span class="n">RA</span><span class="p">)</span> <span style="color: #aa2211">-</span> <span class="n">clampRA</span><span class="p">(</span><span class="n">raOut</span><span style="color: #aa2211">-></span><span class="n">text</span><span class="p">()))</span> <span style="color: #aa2211"><</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #601200">15000</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QTest</span><span style="color: #aa2211">::</span><span class="n">qWait</span><span class="p">(</span><span style="color: #601200">100</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I had a certain number of rounding issues with the Simulator telescope, and ended up testing closeness instead of equality.<br />
I'm not sure this is expected from the Simulator Telescope, but I know this happens with real mounts, so...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27678">https://phabricator.kde.org/D27678</a></div></div><br /><div><strong>To: </strong>TallFurryMan, KStars, mutlaqja<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>