<table><tr><td style="">TallFurryMan added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26509">View Revision</a></tr></table><br /><div><div><p>I cannot test this, so I offer pedantic comments ;)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26509#inline-149470">View Inline</a><span style="color: #4b4d51; font-weight: bold;">indifocuser.cpp:178</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">dir</span> <span style="color: #aa2211">==</span> <span class="n">FOCUS_INWARD</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">steps</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span class="n">steps</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">focusProp</span> <span style="color: #aa2211">=</span> <span class="n">baseDevice</span><span style="color: #aa2211">-></span><span class="n">getNumber</span><span class="p">(</span><span style="color: #766510">"manualfocusdrive"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This makes "steps" the opposite of its previous value. If your intent is to make an inward move result in a negative value, you should consider the sign of "steps" at some point.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26509#inline-149471">View Inline</a><span style="color: #4b4d51; font-weight: bold;">indifocuser.cpp:185</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">abs</span><span class="p">(</span><span class="n">steps</span><span class="p">)</span> <span style="color: #aa2211"><</span> <span style="color: #601200">2</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">steps</span> <span style="color: #aa2211">=</span> <span style="color: #601200">2</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If your observation is that the <a href="https://phabricator.kde.org/Z6" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">Z6</a> fails on steps = 1, you should test for that. Your code is stating that values - 1, 0 and +1 make the <a href="https://phabricator.kde.org/Z6" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">Z6</a> fail.</p>
<p style="padding: 0; margin: 8px;">If you noticed your specific device has a deviation, you might want to create an informative flag when the property is created, instead of comparing a string everytime you move the focuser. But this is minor.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26509">https://phabricator.kde.org/D26509</a></div></div><br /><div><strong>To: </strong>zyziuk, KStars<br /><strong>Cc: </strong>TallFurryMan, kde-edu, narvaez, apol<br /></div>