<table><tr><td style="">mutlaqja added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26250">View Revision</a></tr></table><br /><div><div><p>Great work, please check the comment!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26250#inline-147875">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fpackutil.c:1026</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">single</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">single</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">stat</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span> <span style="color: #74777d">/* special status flag to force output primary array */</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The bracket style we follow is different. We use ANSI style. I suggest create ~/.astylerc file and add to it the following:</p>
<p style="padding: 0; margin: 8px;">--style=allman<br />
--align-reference=name<br />
--indent-switches<br />
--indent-modifiers<br />
--indent-classes<br />
--pad-oper<br />
--indent-col1-comments<br />
--lineend=linux</p>
<p style="padding: 0; margin: 8px;">Of course, you need to install astyle on your system. in QtCreator, you can configure it so that it applies that style everything it saves the file.. this way it will always be in the same coding style used in the project.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26250#inline-147876">View Inline</a><span style="color: #4b4d51; font-weight: bold;">hipsmanager.cpp:390</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">int</span> <span class="n">cost</span> <span style="color: #aa2211">=</span> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">image</span><span style="color: #aa2211">-><span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">byteCount</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">cost</span> <span style="color: #aa2211">=</span> <span class="n">item</span><span style="color: #aa2211">-></span><span class="n">image</span><span style="color: #aa2211">-><span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">sizeInBytes</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cache</span><span class="p">.</span><span class="n">add</span><span class="p">(</span><span class="n">key</span><span class="p">,</span> <span class="n">item</span><span class="p">,</span> <span class="n">cost</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you check when this was introduced in Qt as well?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26250#inline-147877">View Inline</a><span style="color: #4b4d51; font-weight: bold;">hipsrenderer.cpp:167</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_rendered</span><span style="color: #aa2211">++</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_size</span> <span style="color: #aa2211">+=</span> <span class="n">image</span><span style="color: #aa2211">-><span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">byteCount</span></span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_size</span> <span style="color: #aa2211">+=</span> <span class="n">image</span><span style="color: #aa2211">-><span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">sizeInBytes</span></span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same as above.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26250#inline-147878">View Inline</a><span style="color: #4b4d51; font-weight: bold;">skyqpainter.cpp:913</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">qMark</span> <span style="color: #aa2211">=</span> <span style="color: #766510">" ? "</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">double</span> <span class="n">scaleFactor</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0.8</span> <span style="color: #aa2211">*</span> <span class="n">size</span> <span style="color: #aa2211">/</span> <span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="p">(</span><span class="n">qMark</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span> <span class="n">scaleFactor</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0.8</span> <span style="color: #aa2211">*</span> <span class="n">size</span> <span style="color: #aa2211">/</span> <span class="n">fontMetrics</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">horizontalAdvance</span></span><span class="p">(</span><span class="n">qMark</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">f</span><span class="p">.</span><span class="n">setPointSizeF</span><span class="p">(</span><span class="n">f</span><span class="p">.</span><span class="n">pointSizeF</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="n">scaleFactor</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Same issue about Qt version check. I think by next year (around April/May), we can increase the requirement for KStars Qt version and then get rid of these #if s</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26250">https://phabricator.kde.org/D26250</a></div></div><br /><div><strong>To: </strong>shubham, mutlaqja<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>