<table><tr><td style="">yurchor added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26075">View Revision</a></tr></table><br /><div><div><p>Thanks in advance for fixing the minor issues mentioned below.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26075#inline-146856">View Inline</a><span style="color: #4b4d51; font-weight: bold;">focus.cpp:922</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">bool</span> <span class="n">focusingOut</span> <span style="color: #aa2211">=</span> <span class="n">amount</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">dirStr</span> <span style="color: #aa2211">=</span> <span class="n">focusingOut</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"outward"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"inward"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">lastFocusDirection</span> <span style="color: #aa2211">=</span> <span class="n">focusingOut</span> <span style="color: #aa2211">?</span> <span style="color: #a0a000">FOCUS_OUT</span> <span class="p">:</span> <span class="n">FOCUS_IN</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That should be i18n("outward") and i18n("inward")</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26075#inline-146857">View Inline</a><span style="color: #4b4d51; font-weight: bold;">focus.cpp:940</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">currentFocuser</span><span style="color: #aa2211">-></span><span class="n">moveRel</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">ms</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">appendLogText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Focusing <span class="bright">outward</span> by %1 steps..."</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">ms</span></span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">currentFocuser</span><span style="color: #aa2211">-></span><span class="n">moveRel</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">amount</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">appendLogText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Focusing <span class="bright">%2</span> by %1 steps..."</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">absAmount</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">dirStr</span></span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That should be i18np().</p>

<p style="padding: 0; margin: 8px;"><a href="https://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26075#inline-146858">View Inline</a><span style="color: #4b4d51; font-weight: bold;">focus.cpp:1675</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">appendLogText</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Autofocus complete after %1 iterations."</span><span class="p">,</span> <span class="n">hfr_position</span><span class="p">.</span><span class="n">count</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">stop</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That should be i18np().</p>

<p style="padding: 0; margin: 8px;"><a href="https://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/Development/Tutorials/Localization/i18n#Plurals</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26075#inline-146859">View Inline</a><span style="color: #4b4d51; font-weight: bold;">focusalgorithms.h:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/*  Ekos Focus Algorithms</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">    Copyright (C) 2019 Hy Murveit</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It would be better to put some email here, otherwise, we will have one more EBN warning about copyright:</p>

<p style="padding: 0; margin: 8px;"><a href="http://ebn.kde.org/krazy/reports/extragear/edu/kstars/index.html" class="remarkup-link" target="_blank" rel="noreferrer">http://ebn.kde.org/krazy/reports/extragear/edu/kstars/index.html</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26075">https://phabricator.kde.org/D26075</a></div></div><br /><div><strong>To: </strong>murveit, mutlaqja<br /><strong>Cc: </strong>yurchor, kde-edu, narvaez, apol<br /></div>