<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24212">View Revision</a></tr></table><br /><div><div><p>There's some more other lists that maybe are not const, not sure if we care a lot though, but it's always too have "the best code possible"</p>
<p>Up to you if you want to change it or not</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137083">View Inline</a><span style="color: #4b4d51; font-weight: bold;">equationhighlighter.cpp:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringList</span> <span class="n">variables</span> <span style="color: #aa2211">=</span> <span class="n">m_parent</span><span style="color: #aa2211">-></span><span class="n">m_equation</span><span style="color: #aa2211">-></span><span class="n">variables</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringList</span> <span class="n">functions</span> <span style="color: #aa2211">=</span> <span class="n">XParser</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">predefinedFunctions</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">XParser</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">userFunctions</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">mark variables and functions as const?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137084">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:392</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">listSplit</span> <span style="color: #aa2211">=</span> <span class="n">m_fstr</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span> <span class="n">p1</span><span style="color: #aa2211">+</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">p2</span><span style="color: #aa2211">-</span><span class="n">p1</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span> <span class="p">).</span><span class="n">split</span><span class="p">(</span> <span style="color: #766510">','</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">SkipEmptyParts</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Variables shouldn't contain spaces!</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">what would you think of</p>
<p style="padding: 0; margin: 8px;">const QStringList listSplit = ( (p1 != -1) && (p2 != -1) ) ? m_fstr.mid( p1+1, p2-p1-1 ).split( ',', QString::SkipEmptyParts ) : {};</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137298">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:622</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">Equation</span> <span style="color: #aa2211">*</span> <span class="n">e<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">eq</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Equation</span> <span style="color: #aa2211">*</span> <span style="color: #a0a000">e<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">eq</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">delete</span> <span class="n">e</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qDeleteAll?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137299">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:834</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">Plot</span> <span class="n">plot<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//krazy:exclude=foreach</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Plot</span> <span style="color: #a0a000">plot<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: #aa2211">!</span><span class="n">plotAppearance</span><span class="p">(</span><span class="n">p</span><span class="p">).</span><span class="n">visible</span> <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137300">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:851</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">Plot</span> <span class="n">plot<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//krazy:exclude=foreach</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Plot</span> <span style="color: #a0a000">plot<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">plot</span><span class="p">.</span><span class="n">stateNumber</span> <span style="color: #aa2211">=</span> <span class="n">i</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137301">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:881</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QList</span><span style="color: #aa2211"><</span> <span class="n">Plot</span> <span style="color: #aa2211">></span> <span class="n">duplicated</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span style="color: #aa2211">></span> <span style="color: #aa2211">&</span><span class="n">signature<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">signatures</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span style="color: #aa4000">const</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span style="color: #aa4000">bool</span><span style="color: #aa2211">></span> <span style="color: #aa2211">&</span><span style="color: #a0a000">signature<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">signatures</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137302">View Inline</a><span style="color: #4b4d51; font-weight: bold;">function.cpp:897</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">Plot</span> <span class="n">plot<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">//krazy:exclude=foreach</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Plot</span> <span style="color: #a0a000">plot<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">list</span> <span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">plot</span><span class="p">.</span><span class="n">pmSignature</span> <span style="color: #aa2211">=</span> <span class="n">pmSignature</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137303">View Inline</a><span style="color: #4b4d51; font-weight: bold;">functioneditor.cpp:126</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96"> QList<name *> widgets = m_editor->findChildren<name *>(); \</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96"> for<span class="bright">each</span> ( name * w<span class="bright">,</span> widgets ) \</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96"> for ( name * w<span class="bright"> :</span> widgets ) \</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96"> connect( w, SIGNAL(signal), this, SLOT(save()) ); \</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137304">View Inline</a><span style="color: #4b4d51; font-weight: bold;">functioneditor.cpp:233</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Now, any IDs left in currentIDs are of functions that have been deleted</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">FunctionListItem</span> <span style="color: #aa2211">*</span> <span class="n">item<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">currentFunctionItems</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">FunctionListItem</span> <span style="color: #aa2211">*</span> <span style="color: #a0a000">item<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">currentFunctionItems</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24212#inline-137305">View Inline</a><span style="color: #4b4d51; font-weight: bold;">functioneditor.cpp:729</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">for<span class="bright">each</span></span> <span class="p">(</span> <span class="n">Equation</span> <span style="color: #aa2211">*</span> <span class="n">eq<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span> <span class="n">f</span><span style="color: #aa2211">-></span><span class="n">eq</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span> <span class="n">Equation</span> <span style="color: #aa2211">*</span> <span style="color: #a0a000">eq<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span> <span class="n">f</span><span style="color: #aa2211">-></span><span class="n">eq</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">eq</span><span style="color: #aa2211">-></span><span class="n">differentialStates</span><span class="p">.</span><span class="n">resetToInitial</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">qAsConst?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24212">https://phabricator.kde.org/D24212</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>aacid, kde-edu, narvaez, apol<br /></div>