<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23419">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23419#inline-132363">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Project.cpp:268</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">formulaVariableColumns</span><span class="p">[</span><span class="n">i</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span class="n">column</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">tempColumn</span><span style="color: #aa2211">-></span><span class="n">setformulVariableColumn<span class="bright">sPath</span></span><span class="p">(</span><span class="n">i</span><span class="p">,</span> <span class="n">column<span class="bright">Path</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">formulaVariableColumns<span class="bright">Path</span></span><span class="p">[</span><span class="n">i</span><span class="p">]</span> <span style="color: #aa2211">==</span> <span class="n">column<span class="bright">Path</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">tempColumn</span><span style="color: #aa2211">-></span><span class="n">setformulVariableColumn</span><span class="p">(</span><span class="n">i</span><span class="p">,</span> <span style="color: #aa4000">co<span class="bright">nst_cast</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span class="n"><span class="bright">Co</span>lumn<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">static_cast</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">Column</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">column</span></span><span class="bright"></span><span class="p"><span class="bright">))</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">where is the pointer column defined?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23419#inline-132364">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Column.cpp:92</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">connect</span><span class="p">(</span><span class="n">m_usedInActionGroup</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QActionGroup</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Column</span><span style="color: #aa2211">::</span><span class="n">navigateTo</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">AbstractColumn</span><span style="color: #aa2211">::</span><span class="n">maskingChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">]{</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">propertiesAvailable</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">false</span><span class="p">;});</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maskingChanged is nowhere called in your patch.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23419#inline-132365">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.h:122</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">void</span> <span style="color: #004012">finalizeLoad</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">connectFormulaColumn</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">AbstractColumn</span><span style="color: #aa2211">*</span> <span class="n">column</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this new function can be made private.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23419#inline-132362">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Spreadsheet.cpp:908</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">child</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">i</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">setSuppressDataChangedSignal</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">child</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">i</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">reset</span><span class="p">(</span><span class="n">child</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">i</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">where is this signal consumed?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23419#inline-132366">View Inline</a><span style="color: #4b4d51; font-weight: bold;">XYCurve.h:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">POINTER_D_ACCESSOR_DECL</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">AbstractColumn</span><span class="p">,</span> <span class="n">yErrorMinusColumn</span><span class="p">,</span> <span class="n">YErrorMinusColumn</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n">QString<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"> </span><span class="n"><span class="bright">y</span>Error<span class="bright">Min</span>usColumnPath<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">CLASS_D_ACCESSOR_DECL</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">QString<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">x</span>Error<span class="bright">Pl</span>usColumnPath<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">XErrorPlusColumnPath</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">CLASS_D_ACCESSOR_DECL</span><span class="p">(</span><span class="n">QString</span><span class="p">,</span> <span class="n">xErrorMinusColumnPath</span><span class="p">,</span> <span class="n">XErrorMinusColumnPath</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">do I see it correctly that with this patch the connection of a column with a curve is lost if the column is renamed? At the moment it's possible to rename the columns (for example from "my great y-data" to "my great and fancy y-data") without affecting the curves - is this not possible anymore since we work now with your patch with names and not with the pointers anymore?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23419">https://phabricator.kde.org/D23419</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>yurchor, kde-edu, narvaez, apol<br /></div>