<table><tr><td style="">gottfried requested changes to this revision.<br />gottfried added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22910">View Revision</a></tr></table><br /><div><div><p>Looks mostly good and works as intended. But its seems you have missed the member declarations and include directives:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">ktouch/src$ grep -r "QSignalMapper"
models/lessonmodel.cpp:#include <QSignalMapper>
models/charactersmodel.h:class QSignalMapper;
models/charactersmodel.h:    QSignalMapper* m_signalMapper;
models/resourcemodel.h:class QSignalMapper;
models/resourcemodel.h:    QSignalMapper* m_signalMapper;
models/resourcemodel.cpp:#include <QSignalMapper>
models/charactersmodel.cpp:#include <QSignalMapper>
models/lessonmodel.h:class QSignalMapper;
models/lessonmodel.h:    QSignalMapper* m_signalMapper;
core/course.cpp:#include <QSignalMapper>
core/keyboardlayout.h:class QSignalMapper;
core/keyboardlayout.h:    QSignalMapper* m_signalMapper;
core/course.h:class QSignalMapper;
core/course.h:    QSignalMapper* m_signalMapper;
core/keyboardlayout.cpp:#include <QSignalMapper></pre></div>

<p>Can you please remove these?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22910#inline-129421">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lessonmodel.cpp:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">m_signalMapper</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">setMapping</span></span><span class="p">(</span><span class="n">m_course</span><span style="color: #aa2211">-></span><span class="n">lesson</span><span class="p">(</span><span class="n">i</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">connect</span></span><span class="p">(</span><span class="n">m_course</span><span style="color: #aa2211">-></span><span class="n">lesson</span><span class="p">(</span><span class="n">i</span><span class="p">),</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">Lesson</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">titleChanged</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">this</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n"><span class="bright">emitLessonChanged</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">i</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">m_course</span><span style="color: #aa2211">-></span><span class="n">lesson</span><span class="p">(</span><span class="n">i</span><span class="p">),</span> <span style="color: #aa2211">&</span><span class="n">Lesson</span><span style="color: #aa2211">::</span><span class="n">newCharactersChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa2211">=</span><span class="p">]</span> <span class="p">{</span> <span class="n">emitLessonChanged</span><span class="p">(</span><span class="n">i</span><span class="p">);</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">updateMappings</tt> is called multiple times. If I am not mistaken, this will result in multiple connections to the lambda with different values of <tt style="background: #ebebeb; font-size: 13px;">ì</tt> of you don't <tt style="background: #ebebeb; font-size: 13px;">disconnect()</tt> first.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R336 KTouch</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22910">https://phabricator.kde.org/D22910</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Edu, gottfried<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>