<table><tr><td style="">asemke added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21575">View Revision</a></tr></table><br /><div><div><p>There are couple of easy-to-fix compiler warnings</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:738:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotActionMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:752:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotActionMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:766:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotCursorMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:783:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotActionMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:797:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotActionMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:811:32: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if (cartesianPlotCursorMode() == WorksheetView::ApplyActionToAll) {
            ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:843:31: warning: comparison of two values with different enumeration types ('Worksheet::CartesianPlotActionMode' and 'WorksheetView::CartesianPlotActionMode') [-Wenum-compare]
        if(cartesianPlotCursorMode() == WorksheetView::ApplyActionToAll){
           ~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:997:7: warning: unused variable 'curveCount' [-Wunused-variable]
                int curveCount = treeModel->rowCount(plotIndex);
                    ^
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:1037:7: warning: unused variable 'curveCount' [-Wunused-variable]
                int curveCount = treeModel->rowCount(plotIndex);
                    ^
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:1208:8: warning: unused variable 'rowCount' [-Wunused-variable]
                        int rowCount = treeModel->rowCount(plotName);
                            ^
/Users/d058339/Projekte/labplot/src/backend/worksheet/Worksheet.cpp:1209:9: warning: unused variable 'success' [-Wunused-variable]
                        bool success = treeModel->insertRows(treeModel->rowCount(plotName), 1, plotName);

/Users/d058339/Projekte/labplot/src/backend/worksheet/TreeModel.cpp:36:2: warning: field 'parentItem' will be initialized after field 'itemData' [-Wreorder]
        parentItem(parent),
        ^
/Users/d058339/Projekte/labplot/src/backend/worksheet/TreeModel.cpp:315:19: warning: code will never be executed [-Wunreachable-code]
    bool result = rootItem->setData(section, value);
                  ^~~~~~~~
/Users/d058339/Projekte/labplot/src/backend/worksheet/TreeModel.cpp:312:60: warning: code will never be executed [-Wunreachable-code]
    if (role != Qt::EditRole || role != Qt::DisplayRole || orientation != Qt::Horizontal)</pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21575">https://phabricator.kde.org/D21575</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>sgerlach, kde-edu, narvaez, apol<br /></div>