<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21575">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127358">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianCoordinateSystem.cpp:711</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">limit</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// set to max/min if passed over</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use temp vars here too?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127363">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlot.cpp:2641</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">cursor1EnableChanged</span><span class="p">(</span><span class="n">cursor1Enable</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span><span style="color: #aa4000">else</span><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">cursor0Enable</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use spaces: } else {</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127364">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlot.cpp:2661</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">logicalPos</span><span class="p">.</span><span class="n">x</span><span class="p">()</span> <span style="color: #aa2211"><</span> <span class="n">xMin</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">logicalPos</span><span class="p">.</span><span class="n">setX</span><span class="p">(</span><span class="n">xMin</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">space after "if": if (...)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127365">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlot.cpp:2690</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">cursorNumber</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">cursor0Enable</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe better:<br />
cursorNumber == 0 ? cursor0Enable = true : cursor1Enable = true;</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127359">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlot.cpp:2804</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointF</span> <span class="n">p1</span><span class="p">(</span><span class="n">logicalPos</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">cursorNumber</span> <span style="color: #aa2211">==</span> <span style="color: #601200">0</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">cursor0Pos</span> <span style="color: #aa2211">=</span> <span class="n">p1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe better:<br />
cursorNumber == 0 ? cursor0Pos = p1 : cursor1Pos = p1;</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127360">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlot.cpp:2972</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span> <span class="n">cursorPenWidth2</span> <span style="color: #aa2211">=</span> <span class="n">cursorPen</span><span class="p">.</span><span class="n">width</span><span class="p">()</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">cursorPenWidth2</span> <span style="color: #aa2211">=</span> <span class="n">cursorPenWidth2</span> <span style="color: #aa2211"><</span> <span style="color: #601200">10</span> <span style="color: #aa2211">?</span> <span style="color: #601200">10</span> <span style="color: #aa2211">:</span> <span class="n">cursorPenWidth2</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">cursor0Enable</span> <span style="color: #aa2211">&&</span> <span class="n">abs</span><span class="p">(</span><span class="n">point</span><span class="p">.</span><span class="n">x</span><span class="p">()</span><span style="color: #aa2211">-</span><span class="n">cSystem</span><span style="color: #aa2211">-></span><span class="n">mapLogicalToScene</span><span class="p">(</span><span class="n">QPointF</span><span class="p">(</span><span class="n">cursor0Pos</span><span class="p">.</span><span class="n">x</span><span class="p">(),</span><span class="n">yMin</span><span class="p">)).</span><span class="n">x</span><span class="p">())</span> <span style="color: #aa2211"><</span> <span class="n">cursorPenWidth2</span><span class="p">)</span> <span style="color: #aa2211">||</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same as<br />
if (cursorPenWidth2 < 10)<br />
cursorPenWidth2 = 10;</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127366">View Inline</a><span style="color: #4b4d51; font-weight: bold;">XYCurve.cpp:2314</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">double</span> <span class="n">value</span> <span style="color: #aa2211">=</span> <span class="n">column</span><span class="p">[</span><span class="n">row</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">abs</span><span class="p">(</span><span class="n">value</span> <span style="color: #aa2211">-</span> <span class="n">x</span><span class="p">)</span> <span style="color: #aa2211"><=</span> <span class="n">abs</span><span class="p">(</span><span class="n">prevValue</span> <span style="color: #aa2211">-</span> <span class="n">x</span><span class="p">))</span> <span class="p">{</span> <span style="color: #74777d">// "<=" prevents also that row - 1 become < 0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">row</span> <span style="color: #aa2211"><</span> <span class="n">rowCount</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">prevValue</span> <span style="color: #aa2211">=</span> <span class="n">value</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">do you really want abs() defined as<br />
int abs(int)<br />
or fabs() defined as<br />
double fabs(double)<br />
or even qAbs() defined as<br />
T qAbs(const T&)</p>
<p style="padding: 0; margin: 8px;">please check all places where abs() is used</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127361">View Inline</a><span style="color: #4b4d51; font-weight: bold;">WorksheetView.cpp:1816</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_cartesianPlotMouseMode</span> <span style="color: #aa2211">=</span> <span class="n">CartesianPlot</span><span style="color: #aa2211">::</span><span class="n">ZoomYSelectionMode</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">else</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="n">action</span> <span style="color: #aa2211">==</span> <span class="n">cartesianPlotCursorModeAction</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_cartesianPlotMouseMode</span> <span style="color: #aa2211">=</span> <span class="n">CartesianPlot</span><span style="color: #aa2211">::</span><span class="n">Cursor</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no brackets for one-liners</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127362">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CartesianPlotDock.cpp:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ui</span><span class="p">.</span><span class="n">cbCursorLineStyle</span><span style="color: #aa2211">-></span><span class="n">clear</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ui</span><span class="p">.</span><span class="n">cbCursorLineStyle</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"NoPen"</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ui</span><span class="p">.</span><span class="n">cbCursorLineStyle</span><span style="color: #aa2211">-></span><span class="n">addItem</span><span class="p">(</span><span style="color: #766510">"SolidLine"</span><span class="p">,</span> <span style="color: #601200">1</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is Qt::PenStyle, right?<br />
Can we use a global const QStringList containing the names? Also translation would be good :-)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21575#inline-127367">View Inline</a><span style="color: #4b4d51; font-weight: bold;">XYCurveDock.cpp:513</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">path</span> <span style="color: #aa2211">=</span> <span class="n">m_curve</span><span style="color: #aa2211">-></span><span class="n">xColumnPath</span><span class="p">().</span><span class="n">split</span><span class="p">(</span><span style="color: #766510">"/"</span><span class="p">).</span><span class="n">last</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_curve</span><span style="color: #aa2211">-></span><span class="n">xColumn</span><span class="p">()){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">path</span> <span style="color: #aa2211">+=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"</span><span style="color: #bb6622">\t</span><span style="color: #766510"> "</span><span class="p">)</span><span style="color: #aa2211">+</span><span class="n">m_curve</span><span style="color: #aa2211">-></span><span class="n">xColumn</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">plotDesignationString</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">space before {</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21575">https://phabricator.kde.org/D21575</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>sgerlach, kde-edu, narvaez, apol<br /></div>