<table><tr><td style="">sgerlach added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22496">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127136">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:304</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">(</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">*</span> <span class="n">gsl_pow_2</span><span class="p">(</span><span class="n">std</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">])</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">df</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span class="n">statisticValue<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="p">(</span><span class="n">mean</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">-</span> <span class="n">mean</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">])</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span class="n">sp</span> <span style="color: #aa2211">*</span> <span class="n">qSqrt</span><span class="p">(</span><span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n">statisticValue<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">append</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>(</span><span class="n">mean</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">-</span> <span class="n">mean</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">])</span> <span style="color: #aa2211">/</span> <span class="p">(</span><span class="n">sp</span> <span style="color: #aa2211">*</span> <span class="n">qSqrt</span><span class="p">(</span><span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1.0</span><span style="color: #aa2211">/</span><span class="n">n</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]<span class="bright">)</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">printLine</span><span class="p">(</span><span style="color: #601200">9</span><span class="p">,</span> <span style="color: #766510">"<b>Assumption:</b> Equal Variance b/w both population means"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would suggest to use sqrt() from cmath instead of qSqrt(). What do you think?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127137">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:747</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span> <span class="n">ss_a</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span> <span class="n">i</span> <span style="color: #aa2211"><</span> <span class="n">np_a</span><span class="p">;</span> <span class="n">i</span><span style="color: #aa2211">++</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you are doing a lot of basic statistical calculations. Can you check if any GSL function can be used (see <a href="https://www.gnu.org/software/gsl/doc/html/statistics.html" class="remarkup-link" target="_blank" rel="noreferrer">https://www.gnu.org/software/gsl/doc/html/statistics.html</a>)?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127143">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:843</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">level</span><span style="color: #aa2211">++</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rowMajor</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">Cell</span><span class="p">(</span><span style="color: #766510">"Interaction"</span><span class="p">,</span> <span class="n">level</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rowMajor</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">Cell</span><span class="p">(</span><span class="n">round</span><span class="p">(</span><span class="n">ss_interaction</span><span class="p">),</span> <span class="n">level</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">translation?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127142">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:849</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">level</span><span style="color: #aa2211">++</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rowMajor</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">Cell</span><span class="p">(</span><span style="color: #766510">"Within"</span><span class="p">,</span> <span class="n">level</span><span class="p">,</span> <span style="color: #304a96">true</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">rowMajor</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">Cell</span><span class="p">(</span><span class="n">round</span><span class="p">(</span><span class="n">ss_within</span><span class="p">),</span> <span class="n">level</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">translation?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22496#inline-127138">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:1375</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pValue</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">pValue<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #601200">1</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span class="n">pValue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">pValue<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span>;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">check indentation</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22496">https://phabricator.kde.org/D22496</a></div></div><br /><div><strong>To: </strong>devanshuagarwal, Stefan, asemke<br /><strong>Cc: </strong>sgerlach, kde-edu, narvaez, apol<br /></div>