<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22097">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124490">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:173</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">auto</span><span style="color: #aa2211">*</span> <span style="color: #a0a000">col</span> <span class="p">:</span> <span class="n">dataSourceSpreadsheet</span><span style="color: #aa2211">-></span><span class="n">children</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">></span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">all_columns</span> <span style="color: #aa2211"><<</span> <span class="n">col</span><span style="color: #aa2211">-></span><span class="n">name</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no brackets for one-liners.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124492">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:225</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">></span> <span class="n">col_name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">base_col_name</span> <span style="color: #aa2211">=</span> <span style="color: #766510">""</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we use camel case naming convention except of the C-code in NSL. So, colName, etc.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124491">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMap</span><span style="color: #aa2211"><</span><span class="n">QString</span><span class="p">,</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">></span> <span class="n">col_name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">base_col_name</span> <span style="color: #aa2211">=</span> <span style="color: #766510">""</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">np</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no need for an extra assignment. The string is initialized as an empty string.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124493">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:330</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_columns</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span style="color: #601200">2</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">printError</span><span class="p">(</span><span style="color: #766510">"Inappropriate number of columns selected"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">changed</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">no i18n here and below in other printError calls?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124495">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:498</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span><span style="color: #aa2211">*</span> <span class="n">ni</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">int</span><span class="p">[</span><span class="n">np</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span><span style="color: #aa2211">*</span> <span class="n">sum</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">double</span><span class="p">[</span><span class="n">np</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span><span style="color: #aa2211">*</span> <span class="n">mean</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">double</span><span class="p">[</span><span class="n">np</span><span class="p">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">where are the deletes for these arrays?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124496">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:566</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_stats_table</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span> <span style="color: #766510">"<h3>Group Summary Statistics</h3>"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">put h3 tags outside of the i18n call here and in other similar places in the code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124497">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:579</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">row_major</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">""</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"Between Groups"</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"Within Groups"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">i18n?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124498">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:582</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">base_index</span> <span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">base_index</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span> <span style="color: #aa2211">*</span> <span class="n">column_count</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"Sum of Squares"</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">s_b</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">s_w</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">base_index</span> <span style="color: #aa2211">=</span> <span style="color: #601200">2</span> <span style="color: #aa2211">*</span> <span class="n">column_count</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"Degree of Freedom"</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">f_b</span><span class="p">;</span> <span class="n">row_major</span><span class="p">[</span><span class="n">base_index</span> <span style="color: #aa2211">+</span> <span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">=</span> <span class="n">f_w</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">i18n?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124499">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTest.cpp:641</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span><span style="color: #aa2211">*</span> <span class="n">yi_bar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">double</span><span class="p">[</span><span class="n">np</span><span class="p">];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">double</span><span style="color: #aa2211">*</span> <span class="n">zi_bar</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span style="color: #aa4000">double</span><span class="p">[</span><span class="n">np</span><span class="p">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">where are the deletes for these arrays?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124500">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">explicit</span> <span class="n">HypothesisTestPrivate</span><span class="p">(</span><span class="n">HypothesisTest</span><span style="color: #aa2211">*</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">virtual</span> <span style="color: #aa2211">~</span><span class="n">HypothesisTestPrivate</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">one tab too much here?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124501">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">Spreadsheet</span><span style="color: #aa2211">*</span> <span class="n">dataSourceSpreadsheet</span><span class="p">{</span><span class="n">nullptr</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">*></span> <span class="n">m_columns</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span> <span class="n">all_columns</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">all m_* are private and should be part of the private section.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124502">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:81</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span style="color: #004012">getLine</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">msg</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">color</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"black"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">printLine</span><span class="p">(</span><span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span><span style="color: #aa2211">&</span> <span class="n">index</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">msg</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">color</span> <span style="color: #aa2211">=</span> <span style="color: #766510">"black"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why not to use Qt::GlobalColors instead of QString for the color?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22097#inline-124503">View Inline</a><span style="color: #4b4d51; font-weight: bold;">HypothesisTestPrivate.h:84</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">printError</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&</span> <span class="n">error_msg</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">clearTestView</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">wrong indentation here.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22097">https://phabricator.kde.org/D22097</a></div></div><br /><div><strong>To: </strong>devanshuagarwal, asemke, sgerlach<br /><strong>Cc: </strong>sgerlach, kde-edu, asemke, narvaez, apol<br /></div>