<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22010">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124005">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.cpp:903</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span class="n">disconnect</span><span class="p">(</span><span class="n">m_owner</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">updateFormula</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="bright"></span><span style="color: #74777d"><span class="bright">//</span>disconnect(m_owner, SLOT(updateFormula()));<span class="bright"> // because as sender is THIS used!</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #74777d">// This works:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span class="n">connection</span><span class="p">,</span> <span class="n">m_connectionsUpdateFormula</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ok. We can remove these comments.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124006">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.cpp:904</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #74777d">// This works:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">foreach</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span class="n">connection</span><span class="p">,</span> <span class="n">m_connectionsUpdateFormula</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">disconnect</span><span class="p">(</span><span class="n">connection</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use range based for-loop here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124010">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.cpp:908</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">autoUpdate</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">*></span> <span class="n">columns</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span style="color: #a0a000">column</span> <span class="p">:</span> <span class="n">variableColumns</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this vector doesn't seem to be used. Maybe you can remove it as part of your next patch here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124008">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.cpp:962</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">column</span><span style="color: #aa2211">-></span><span class="n">rowCount</span><span class="p">()</span> <span style="color: #aa2211">></span> <span class="n">maxRowCount</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="n">maxRowCount</span> <span style="color: #aa2211">=</span> <span class="n">column</span><span style="color: #aa2211">-></span><span class="n">rowCount</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">  <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">check indentation here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124009">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.cpp:966</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">Spreadsheet</span><span style="color: #aa2211">*</span> <span class="n">spreadsheet</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">dynamic_cast</span><span style="color: #aa2211"><</span><span class="n">Spreadsheet</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">m_owner</span><span style="color: #aa2211">-></span><span class="n">parentAspect</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">spreadsheet</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">//    // use first column as reference for the minimal number of rows. For the</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this check is obsolete since it must be always a Spreadsheet. You can add an assert here maybe.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124007">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ColumnPrivate.h:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span class="n">Column</span><span style="color: #aa2211">*</span> <span class="n">m_owner</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">Connection</span><span style="color: #aa2211">></span> <span class="n">m_connectionsUpdateFormula</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QVector instead of QList. Not a big difference here, just a matter of convention in the code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124014">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Spreadsheet.cpp:676</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">col</span><span style="color: #aa2211">-></span><span class="n">columnMode</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">AbstractColumn</span><span style="color: #aa2211">::</span><span class="n">Numeric</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      <span class="n">col</span><span style="color: #aa2211">-></span><span class="n">setColumnMode</span><span class="p">(</span><span class="n">AbstractColumn</span><span style="color: #aa2211">::</span><span class="n">Numeric</span><span class="p">);</span> <span style="color: #74777d">// wieso??</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we allow to trigger this "Generate data from function values" also on integer columns. Since the results of the such calculations are floating point number usually, we convert here to Numeric.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124016">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Spreadsheet.h:72</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">void</span> <span style="color: #004012">updateColumnValues</span><span class="p">(</span><span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">Column</span><span style="color: #aa2211">*></span> <span class="n">columns</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">expression</span><span class="p">,</span> <span class="n">QStringList</span> <span class="n">variableNames</span><span class="p">,</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">Column</span> <span style="color: #aa2211">*></span> <span class="n">variableColumns</span><span class="p">,</span> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">QVector</span><span style="color: #aa2211"><</span><span style="color: #aa4000">double</span><span style="color: #aa2211">></span> <span style="color: #aa2211">*></span> <span class="n">xVectors</span><span class="p">,</span> <span style="color: #aa4000">bool</span> <span class="n">autoUpdate</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we can work with references here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124017">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FunctionValuesDialog.cpp:367</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #74777d">//resize the spreadsheet if one of the data vectors from other spreadsheet(s) has more elements then the current spreadsheet.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_spreadsheet</span><span style="color: #aa2211">-></span><span class="n">rowCount</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span> <span class="n">maxRowCount</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_spreadsheet</span><span style="color: #aa2211">-></span><span class="n">rowCount</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span> <span class="n">maxRowCount</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// if to many rows, delete to save memory</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_spreadsheet</span><span style="color: #aa2211">-></span><span class="n">setRowCount</span><span class="p">(</span><span class="n">maxRowCount</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">what happens now if m_spreadsheet->rowCount() < maxRowCount?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22010#inline-124015">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FunctionValuesDialog.cpp:372</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">  <span style="color: #aa4000">bool</span> <span class="n">autoUpdate</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">ui</span><span class="p">.</span><span class="n">chkAutoUpdate</span><span style="color: #aa2211">-></span><span class="n">checkState</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Checked</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span class="bright"></span><span style="color: #aa4000"><span class="bright">for</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #a0a000"><span class="bright">col</span></span><span class="bright"> </span><span class="p"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">m_columns</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">col</span><span style="color: #aa2211">-></span><span class="n">columnMode</span><span class="p">()</span> <span style="color: #aa2211">!=</span> <span class="n">AbstractColumn</span><span style="color: #aa2211">::</span><span class="n">Numeric</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">      <span class="n">col</span><span style="color: #aa2211">-></span><span class="n">setColumnMode</span><span class="p">(</span><span class="n">AbstractColumn</span><span style="color: #aa2211">::</span><span class="n">Numeric</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">col</span><span style="color: #aa2211">-></span><span class="n">setFormula</span><span class="p">(</span><span class="n">expression</span><span class="p">,</span> <span class="n">variableNames</span><span class="p">,</span> <span class="n">columns</span><span class="p">,</span> <span class="n">autoUpdate</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">col</span><span style="color: #aa2211">-></span><span class="n">replaceValues</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">,</span> <span class="n">new_data</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">  <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="bright"></span><span class="n"><span class="bright">m_spreadsheet</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">updateColumnValues</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">m_columns</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">expression</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">variableNames</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">columns</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">xVectors</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">autoUpdate</span></span><span class="bright"></span><span class="p"><span class="bright">);</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You removed the usage of ExpressinParser here. We can remove the include "EvaluationParser.h" in this file, too.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22010">https://phabricator.kde.org/D22010</a></div></div><br /><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>sgerlach, kde-edu, narvaez, apol<br /></div>