<table><tr><td style="">amankumargupta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21893">View Revision</a></tr></table><br /><div><div><p>lots of trailing whitespaces.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123936">View Inline</a><span style="color: #4b4d51; font-weight: bold;">MagicHat.qml:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">levels:</span> <span style="color: #004012">activity</span><span class="p">.</span><span style="color: #004012">datasetLoader</span><span class="p">.</span><span style="color: #004012">item</span><span class="p">.</span><span style="color: #004012">data</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">range:</span> <span style="color: #004012">activity</span><span class="p">.</span><span style="color: #004012">datasetLoader</span><span class="p">.</span><span style="color: #004012">item</span><span class="p">.</span><span style="color: #004012">range</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #004012">alias</span> <span style="color: #aa4000">bonus:</span> <span style="color: #004012">bonus</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"calculation_range" would be better?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123941">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #004012"><span class="bright">coefficientsNeeded</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">range</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">30</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">j</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">j</span><span style="color: #aa2211"><</span><span style="color: #601200">3</span><span class="p">;</span> <span style="color: #004012">j</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">don't use hardcoded values. Keep it in a variable and use that variable it. Will be more flexible and easy for anyone to find modify it he wants.<br />
Also, please add a comment mentioning why items.range / 30 <= 1 is done. Improves readability of the code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123942">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span style="color: #004012"><span class="bright">coefficientsNeeded</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">range</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">30</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">false</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">j</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">j</span><span style="color: #aa2211"><</span><span style="color: #601200">3</span><span class="p">;</span> <span style="color: #004012">j</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">repeatersList</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">].</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">j</span><span class="p">).</span><span style="color: #004012">initStars</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing spaces between operators and operands.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123943">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:86</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #004012"><span class="bright">numberOfStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">getRandomInt</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">8</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">break</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">case</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">5</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">numberOfStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">getRandomInt</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">2</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">maxValue</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">var</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">subtractor</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">mode</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"minus"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #004012"><span class="bright">numberOfStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">levels</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">currentLevel</span></span><span class="bright"></span><span class="p"><span class="bright">].</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">maxStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">getRandomInt</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">levels</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">currentLevel</span></span><span class="bright"></span><span class="p"><span class="bright">].</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">minStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">],</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">items</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">levels</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">currentLevel</span></span><span class="bright"></span><span class="p"><span class="bright">].</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">maxStars</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">coffieients</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">])</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">-</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">subtractor</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Put the expressions in parenthesis. Same comment for the ones below.<br />
Improves code readability.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123945">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:130</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211"><</span><span style="color: #601200">3</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">repeatersList</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">].</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">i</span><span class="p">).</span><span style="color: #004012">coefficientVisible</span> <span style="color: #aa2211">=</span> <span style="color: #004012">visibility</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">repeatersList</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">i</span><span class="p">).</span><span style="color: #004012">coefficientVisible</span> <span style="color: #aa2211">=</span> <span style="color: #004012">visibility</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why not use a nested loop from 0 to 2?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123946">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span><span class="p">(</span><span style="color: #aa4000">var</span> <span style="color: #004012">i</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211"><</span><span style="color: #601200">3</span><span class="p">;</span> <span style="color: #004012">i</span><span style="color: #aa2211">++</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">repeatersList</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">].</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">i</span><span class="p">).</span><span style="color: #004012">starsColor</span> <span style="color: #aa2211">=</span> <span style="color: #004012">colorValue</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">repeatersList</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #004012">i</span><span class="p">).</span><span style="color: #004012">starsColor</span> <span style="color: #aa2211">=</span> <span style="color: #004012">colorValue</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">nested loop would be better</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123948">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #aa4000">function</span> <span style="color: #004012">verifyAnswer</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">range</span> <span style="color: #aa2211">/</span> <span style="color: #601200">30</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">numberOfUserStars</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">===</span> <span style="color: #004012">nbStarsToCount</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">&&</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The same thing for this formula like I said previously for the one above.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21893#inline-123950">View Inline</a><span style="color: #4b4d51; font-weight: bold;">magic-hat.js:166</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">userStars</span> <span style="color: #aa2211">=</span> <span style="color: #004012">numberOfUserStars</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">*</span> <span style="color: #004012">answerCofficients</span><span class="p">[</span><span style="color: #601200">0</span><span class="p">]</span> <span style="color: #aa2211">+</span> <span style="color: #004012">numberOfUserStars</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">*</span> <span style="color: #004012">answerCofficients</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">]</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">numberOfUserStars</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">*</span> <span style="color: #004012">answerCofficients</span><span class="p">[</span><span style="color: #601200">2</span><span class="p">];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you rename these two variables to more understandable names (this one and the one below)?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21893">https://phabricator.kde.org/D21893</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Improvements, timotheegiet<br /><strong>Cc: </strong>amankumargupta, timotheegiet, GCompris: Improvements, kde-edu, GCompris, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, echarruau, andreask, rahulyadav, narvaez, scagarwal, apol, jjazeix, bcoudoin<br /></div>