<table><tr><td style="">asemke added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18420">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18420#inline-118586">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractAspect.h:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/// enum values are chosen such that @verbatim inherits(base)@endverbatim</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/// returns true iff the class inherits from @verbatim base@endverbatim.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">///</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">small typo - it should be "if".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18420#inline-118582">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractAspect.h:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">AspectType</span> <span style="color: #004012">type</span><span class="p">()</span> <span style="color: #aa4000">const</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">m_type</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we moved all small and one-line functions except of the tempate functions into the cpp file to keep the header more clean. The compiler will manage to inline these one-liners :-)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18420#inline-118583">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AspectTreeModel.cpp:276</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_selectableAspects</span><span class="p">.</span><span class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">foreach</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">char</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">classString</span></span><span class="p">,</span> <span class="n">m_selectableAspects</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">aspect</span><span style="color: #aa2211">-></span><span class="n">inherits</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">classString</span></span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">foreach</span> <span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">AspectType</span></span><span class="bright"> </span><span class="n"><span class="bright">type</span></span><span class="p">,</span> <span class="n">m_selectableAspects</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">aspect</span><span style="color: #aa2211">-></span><span class="n">inherits</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">type</span></span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">will the range-based for loop work here, too?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18420#inline-118584">View Inline</a><span style="color: #4b4d51; font-weight: bold;">LabPlotProjectParser.cpp:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">LabPlotProjectParser</span><span style="color: #aa2211">::</span><span class="n">LabPlotProjectParser</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">ProjectParser</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_topLevelClasses<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Folder"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Workbook"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Spreadsheet"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Matrix"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Worksheet"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"CantorWorksheet"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Datapicker"</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"LiveDataSource"</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_topLevelClasses<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">AspectType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Folder</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span class="n"><span class="bright">AspectType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Workbook</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">AspectType</span><span style="color: #aa2211">::</span><span class="n">Spreadsheet</span> <span style="color: #aa2211"><<</span> <span class="n">AspectType</span><span style="color: #aa2211">::</span><span class="n">Matrix</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">list initialization also here as you did in AxisDock::setModel()?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18420#inline-118585">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OriginProjectParser.cpp:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">OriginProjectParser</span><span style="color: #aa2211">::</span><span class="n">OriginProjectParser</span><span class="p">()</span> <span style="color: #aa2211">:</span> <span class="n">ProjectParser</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">m_topLevelClasses</span> <span style="color: #aa2211"><<</span> <span class="bright"></span><span style="color: #766510"><span class="bright">"</span>Folder<span class="bright">"</span></span> <span style="color: #aa2211"><<</span> <span class="bright"></span><span style="color: #766510"><span class="bright">"</span>Workbook<span class="bright">"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Spreadsheet"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Matrix"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Worksheet"</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright"><<</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Note"</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_topLevelClasses</span> <span style="color: #aa2211"><<</span> <span class="bright"></span><span class="n"><span class="bright">AspectType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">Folder</span> <span style="color: #aa2211"><<</span> <span class="bright"></span><span class="n"><span class="bright">AspectType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="n">Workbook</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211"><<</span> <span class="n">AspectType</span><span style="color: #aa2211">::</span><span class="n">Spreadsheet</span> <span style="color: #aa2211"><<</span> <span class="n">AspectType</span><span style="color: #aa2211">::</span><span class="n">Matrix</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">list initialization also here as you did in AxisDock::setModel()?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18420">https://phabricator.kde.org/D18420</a></div></div><br /><div><strong>To: </strong>croick, LabPlot<br /><strong>Cc: </strong>asemke, kde-edu, narvaez, apol<br /></div>