<table><tr><td style="">echarruau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18600">View Revision</a></tr></table><br /><div><div><p>You have been doing a great job, modularising the different ordering activity.<br />
I have added a few comments to the code.<br />
For me your code is not generic enough, the variable names are still referring to numbers when they should refer to items or elements.<br />
Also there is still some parts where I can see some "if number...." we do not need them anymore.<br />
Last but important part, we should be able to present different sets of data for each level in ressources.<br />
Good job, this will be a very very useful activity for any class in the world, we are doing a lots of ordering from 6 years old up to 10 years old, and that in french, numeration or measures.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116011">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ordering_items.js:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">function</span> <span style="color: #004012">getRandomNumbers</span><span class="p">(</span><span style="color: #004012">numOfBoxes</span><span class="p">,</span> <span style="color: #004012">upperBound</span><span class="p">,</span> <span style="color: #004012">lowerBound</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">while</span><span class="p">(</span><span style="color: #004012">num</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211"><</span> <span style="color: #004012">numOfBoxes</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here we do not have numbers but items, we should have a more generic name</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116012">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ordering_items.js:29</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">function</span> <span style="color: #004012">getRandomNumbers</span><span class="p">(</span><span style="color: #004012">numOfBoxes</span><span class="p">,</span> <span style="color: #004012">upperBound</span><span class="p">,</span> <span style="color: #004012">lowerBound</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">while</span><span class="p">(</span><span style="color: #004012">num</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211"><</span> <span style="color: #004012">numOfBoxes</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">var</span> <span style="color: #004012">randomNumber</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">ceil</span><span class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">random</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span style="color: #004012">upperBound</span> <span style="color: #aa2211">-</span> <span style="color: #004012">lowerBound</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">lowerBound</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I can not see where the variable num is coming from, we need to avoid global variable for it to be readable and maintainable.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116013">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dataset.json:4</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"letters"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"data"</span><span style="color: #aa2211">:</span> <span style="color: #aa2211">[</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I can not see what data is doing here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116018">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dataset.json:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"mode"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"image"</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"images"</span><span style="color: #aa2211">:</span> <span style="color: #aa2211">[</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here like for all the other modes: alphabetical or number we should be able to add a set of data per level, so that we can increase the difficulty of the exercice.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116017">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:149</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">boxValue</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">tileType</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"number"</span> <span style="color: #aa2211">||</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">tileType</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"alphabets"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.horizontalCenter:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">horizontalCenter</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We should not have this anymore, your code should be totally generic</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18600">https://phabricator.kde.org/D18600</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Activities, jjazeix<br /><strong>Cc: </strong>jjazeix, echarruau, kde-edu, GCompris: Activities, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin<br /></div>