<table><tr><td style="">amankumargupta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18600">View Revision</a></tr></table><br /><div><div><p>Working of the activity seems good to me. Will look into the code more in-depth in free time.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116055">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:80</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">fontSize:</span> <span style="color: #004012">tinySize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">orderingType</span> <span style="color: #aa2211">===</span> <span style="color: #766510">"ascending"</span> <span style="color: #aa2211">?</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Drag and drop the items in correct position in Ascending order"</span><span class="p">)</span> <span style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Drag and drop the items in correct position in Descending order"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">horizontalAlignment:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">Center</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you enclose items.orderingType === "ascending" within a bracket? Improves readibility.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116056">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Rectangle</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: container</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span class="p">((</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">)).</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">model</span><span class="p">)</span><span style="color: #aa2211">+</span><span class="p">(</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">model</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span><span style="color: #aa2211">*</span><span style="color: #004012">flow</span><span class="p">.</span><span style="color: #004012">spacing</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you find a better name for it?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116057">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:104</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: container</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">min</span><span class="p">(</span><span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">,</span> <span class="p">((</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">itemAt</span><span class="p">(</span><span style="color: #601200">0</span><span class="p">)).</span><span style="color: #004012">width</span><span style="color: #aa2211">*</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">model</span><span class="p">)</span><span style="color: #aa2211">+</span><span class="p">(</span><span style="color: #004012">boxes</span><span class="p">.</span><span style="color: #004012">model</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span><span style="color: #aa2211">*</span><span style="color: #004012">flow</span><span class="p">.</span><span style="color: #004012">spacing</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">height:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span><span style="color: #aa2211">/</span><span style="color: #601200">2</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing indenting spaces between operators and operands.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116058">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Flow</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: flow</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">spacing:</span> <span style="color: #601200">10</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please find a better name for it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116059">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:126</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">fill:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if it's just one anchor property, why not just do anchors.fill: parent? :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116060">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:135</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #766510">"white"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">z:</span> <span style="color: #004012">mouseArea</span><span class="p">.</span><span style="color: #004012">drag</span><span class="p">.</span><span style="color: #004012">active</span> <span style="color: #aa2211">||</span> <span style="color: #004012">mouseArea</span><span class="p">.</span><span style="color: #004012">pressed</span> <span style="color: #aa2211">?</span> <span style="color: #601200">2</span> <span style="color: #aa2211">:</span> <span style="color: #601200">1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #004012">boxValue</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please enclose mouseArea.drag.active || mouseArea.pressed within a bracket to improve readibility</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116061">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:168</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.margins:</span> <span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">ratio</span> <span style="color: #aa2211">*</span> <span style="color: #601200">5</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">source:</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">tileType</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"image"</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">boxValue :</span> <span style="color: #766510">""</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">same comment regarding enclosing within bracket</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-116062">View Inline</a><span style="color: #4b4d51; font-weight: bold;">OrderingNumbers.qml:282</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">sourceSize.width:</span> <span style="color: #601200">70</span> <span style="color: #aa2211">*</span> <span style="color: #004012">ApplicationInfo</span><span class="p">.</span><span style="color: #004012">ratio</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">right:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">right</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indentation.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18600">https://phabricator.kde.org/D18600</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Activities, jjazeix<br /><strong>Cc: </strong>amankumargupta, jjazeix, echarruau, kde-edu, GCompris: Activities, sanjayshetty, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, andreask, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin<br /></div>