<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18600">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-108779">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActivityInfo.qml:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/* GCompris - ActivityInfo.qml</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if the activity didn't exist before, don't forget to change the copyright and year for the corresponding files</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-108778">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dataset.json:17</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa2211">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #766510">"maxNumber"</span><span style="color: #aa2211">:</span> <span style="color: #601200">3</span><span style="color: #aa2211">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #766510">"minNumber"</span><span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">just a quick point, it's not "natural" (at least for me, maybe it's not universal :)) to have the max value before the min</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-108780">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ordering_numbers.js:106</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">var</span> <span style="color: #004012">lowerBound</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">upperBound</span> <span style="color: #aa2211">=</span> <span style="color: #004012">allData</span><span class="p">[</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bar</span><span class="p">.</span><span style="color: #004012">level</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">maxNumber</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">lowerBound</span> <span style="color: #aa2211">=</span> <span style="color: #004012">allData</span><span class="p">[</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bar</span><span class="p">.</span><span style="color: #004012">level</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">minNumber</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you can directly assign on declaration</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-108781">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ordering_numbers.js:108</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #004012">lowerBound</span> <span style="color: #aa2211">=</span> <span style="color: #004012">allData</span><span class="p">[</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">bar</span><span class="p">.</span><span style="color: #004012">level</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">].</span><span style="color: #004012">minNumber</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">while</span><span class="p">(</span><span style="color: #004012">num</span><span class="p">.</span><span style="color: #004012">length</span> <span style="color: #aa2211"><</span> <span style="color: #004012">n</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">var</span> <span style="color: #004012">randomNumber</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">ceil</span><span class="p">(</span><span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">random</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span style="color: #004012">upperBound</span> <span style="color: #aa2211">-</span> <span style="color: #004012">lowerBound</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span style="color: #004012">lowerBound</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">can it be more generic? For now, if we add a new mode, we have to change multiple files. If we can have the possibility to limit the changes on the specific activity files, it would be way better</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18600#inline-108782">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ordering_numbers.js:176</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"number"</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #004012">sortedItems</span><span class="p">.</span><span style="color: #004012">sort</span><span class="p">(</span><span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">a</span><span class="p">,</span> <span style="color: #004012">b</span><span class="p">)</span> <span class="p">{</span> <span style="color: #aa4000">return</span> <span style="color: #004012">a</span> <span style="color: #aa2211">-</span> <span style="color: #004012">b</span> <span class="p">})</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"alphabets"</span> <span style="color: #aa2211">||</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mode</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"image"</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do we need a specific sort function and the sort without argument doesn't work?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18600">https://phabricator.kde.org/D18600</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Activities, jjazeix<br /><strong>Cc: </strong>jjazeix, echarruau, kde-edu, GCompris: Activities, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin<br /></div>