<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17945">View Revision</a></tr></table><br /><div><div><p>In <a href="https://pasteboard.co/I1JH6CR.png" class="remarkup-link" target="_blank" rel="noreferrer">https://pasteboard.co/I1JH6CR.png</a>, there should be some margin so the text do not override with the border.<br />
In <a href="https://pasteboard.co/I1JGVSt.png" class="remarkup-link" target="_blank" rel="noreferrer">https://pasteboard.co/I1JGVSt.png</a>, can you center the "Great" text?<br />
In <a href="https://pasteboard.co/I1JGKBZ.png" class="remarkup-link" target="_blank" rel="noreferrer">https://pasteboard.co/I1JGKBZ.png</a>, it should be a generic definition of "remainder", not division by 2.</p>
<p>Thanks</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106811">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Tutorial2.qml:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/* GCompris - Tutorial1.qml</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">do not forget to update these info when you rename a file</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106812">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Tutorial2.qml:33</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id: even</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"For example: 12, 38, 52, 68, 102, 118, 168, 188, 502, 532, 700, 798, 842, 892 ,1000."</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">" All of these numbers are even numbers as they leave remainder 0 when divided by 2."</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">892, 1000</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106813">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Tutorial5.qml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">isEven:</span> <span style="color: #000a65">false</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">isOdd:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">evenNumber:</span> <span style="color: #004012">isEven</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"52"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"59"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">there is no need for2 bools</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106814">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Tutorial5.qml:31</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">isOdd:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">evenNumber:</span> <span style="color: #004012">isEven</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"52"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"59"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">oddNumber:</span> <span style="color: #aa2211">!</span><span style="color: #004012">isEven</span> <span style="color: #aa2211">?</span> <span style="color: #766510">"52"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"59"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it should be renamed firstChoice or firstNumber, having a variable called "evenNumber" and setting it to 59 is not a good practice</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106816">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TutorialBase.qml:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">message</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">=</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"There is an error:"</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"When divided by 2, 13 is equal to 6 and remainder is 1."</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"Therefore this is an odd number."</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the numbers shouldn't be harcoded here, else it won't work for the examples</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17945#inline-106817">View Inline</a><span style="color: #4b4d51; font-weight: bold;">TutorialBase.qml:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">top:</span> <span style="color: #004012">messageRectangle</span><span class="p">.</span><span style="color: #004012">top</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">topMargin:</span> <span class="p">(</span><span style="color: #004012">message</span><span class="p">.</span><span style="color: #004012">text</span> <span style="color: #aa2211">===</span> <span style="color: #766510">"Great"</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.2</span> <span style="color: #aa2211">:</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">left:</span> <span style="color: #004012">messageRectangle</span><span class="p">.</span><span style="color: #004012">left</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">missing qsTr(). Is there a better way to check that the text has a specific value to set the margin?<br />
With translation, we should not assume anything about the text length</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17945">https://phabricator.kde.org/D17945</a></div></div><br /><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix<br /><strong>Cc: </strong>echarruau, amankumargupta, jjazeix, kde-edu, narvaez, apol<br /></div>