<table><tr><td style="">AkshayCHD added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18230">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/echarruau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@echarruau</a></p>
<p>Diff Update:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Made the answer text slide down when question length is too long</li>
<li class="remarkup-list-item">Moved the buttons up when window height > width</li>
</ol>
<p>Updates to be made:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">Remove the submit button</li>
<li class="remarkup-list-item">Add some sort of timer</li>
<li class="remarkup-list-item">Create separate json files for different types of questions instead of one</li>
</ol></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18230#inline-104364">View Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span style="color: #4b4d51; font-weight: bold;">dataset.json:1</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The issue that Emmanuel is saying is, (as I understand it), is that we only have one dataset.json file for all the categories.<br />
It would be better to use one qml file (to be able to use qsTr()) per category and "dynamically" load the categories instead of having to update the dataset.json.<br />
This would allow to create dataset independantly of the software compilation and be able to use them without having to recompile (we could say to load all qml dataset files in ~/.local/gcompris... for example).</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Okay, I get it now, I'll get on it. Thanks :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18230">https://phabricator.kde.org/D18230</a></div></div><br /><div><strong>To: </strong>AkshayCHD, GCompris: Activities<br /><strong>Cc: </strong>jjazeix, echarruau, kde-edu, GCompris: Activities, parimalprasoon, harrymecwan, ganeshredcobra, nityanandkumar, rahulyadav, narvaez, scagarwal, apol, timotheegiet, bcoudoin<br /></div>