<html><head></head><body>No problems, I'm find with that being removed.<br><br><br><div class="gmail_quote">On 5 February 2019 17:26:37 GMT, Shubham <noreply@phabricator.kde.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18764">View Revision</a><table><tbody><tr><td style="">shubham added inline comments.
</td></tr></tbody></table><br><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18764#inline-104208">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:75</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Port to KDE Frameworks 5"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"laurent DOT navet+klettres AT gmail DOT com"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">about</span><span class="p">.</span><span class="n">addCredit</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"David Precious"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Minor improvements, show both cases"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"davidp@preshweb.co.uk"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry, but you can not credit yourself unless you are a maintainer, developer or a documenter who has done significant amount of contribution to the project.</p></div></div></div></div></div><br><div><strong>REPOSITORY</strong><div><div>R333 KLettres</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18764">https://phabricator.kde.org/D18764</a></div></div><br><div><strong>To: </strong>bigpresh<br><strong>Cc: </strong>shubham, kde-edu, narvaez, apol<br></div></blockquote></div><br>-- <br>Sent from my Android phone with K-9 Mail. Please excuse my brevity.</body></html>