<table><tr><td style="">jjazeix requested changes to this revision.<br />jjazeix added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17850">View Revision</a></tr></table><br /><div><div><p>Thank you for the patch.<br />
I have this warning when I start the activity: qrc:/gcompris/src/core/Tutorial.qml:187:9: Unable to assign [undefined] to QUrl</p>
<p>The same tutorial is also displayed in case of other activities using the same base code (as planegame for example) and it's not expected.</p>
<p>When I continue on the tutorial: qrc:/gcompris/src/activities/planegame/resource/tutorial2.qml:66:7: QML GCText: Cannot anchor to an item that isn't a parent or sibling.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98448">View Inline</a><span style="color: #4b4d51; font-weight: bold;">planegame.js:49</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"instruction"</span><span style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Even numbers are those numbers which leaves remainder 0 when divisible by 2."</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"instructionQml"</span> <span style="color: #aa2211">:</span> <span style="color: #766510">"qrc:/gcompris/src/activities/planegame/resource/tutorial1.qml"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Even numbers are numbers which leave remainder 0 when divisible by 2.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98449">View Inline</a><span style="color: #4b4d51; font-weight: bold;">planegame.js:54</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"instruction"</span><span style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Odd numbers are those numbers which do not leaves remainder 0 when divisible by 2."</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #766510">"instructionQml"</span><span style="color: #aa2211">:</span> <span style="color: #766510">"qrc:/gcompris/src/activities/planegame/resource/tutorial.qml"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">},</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why starting with "tutorial1", then "tutorial", then "tutorial2" as filename and not order them?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98451">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial.qml:13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">GCText</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id :even</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.centerIn:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">Center</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">id: even</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98456">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial.qml:15</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.centerIn:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">Center</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #766510">"For example: \n 15, 19, 51 , 65 , 103 , \n 119 , 169 , 185 , 505 , 533 , \n 701 , 799 , 845 , 897 , 1001. \n All of these numbers are odd numbers as they \n do not leave remainder 0 when divisible by 2."</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">2 spaces between "numbers" and "are"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98455">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial1.qml:13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">anchors.centerIn:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">Center</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #766510">"For example: \n 12 , 38 , 52 , 68 , 102 , \n 118 , 168 , 188 , 502 , 532 , \n 700 , 798 , 842 , 892 , 1000. \n All of these numbers are even numbers as they leave\n remainder 0 when divisible by 2."</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Some spaces shouldn't be there to separate the numbers.<br />
It's not up to the developer to put the \n, the item should correctly handle the break lines and the text should not be outside the screen when we resize it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98460">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial2.qml:13</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">GCText</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">id:text1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">anchors</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">variable naming is not good</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98457">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial2.qml:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"2"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.8</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why do you want to translate 2?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98461">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial2.qml:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">GCText</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"Great"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.5</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you probably can use only one GCText to display if it is good or not and change the text accordingly</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98462">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tutorial3.qml:117</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">GCText</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">qsTr</span><span class="p">(</span><span style="color: #766510">"No,this is not an even number as it do not leaves remainder 0 when divisible by 2."</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: #004012">parent</span><span class="p">.</span><span style="color: #004012">height</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it does not leave</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17850">https://phabricator.kde.org/D17850</a></div></div><br /><div><strong>To: </strong>dekumar, GCompris: Improvements, jjazeix<br /><strong>Cc: </strong>jjazeix, yurchor, kde-edu, narvaez, apol<br /></div>