<table><tr><td style="">tcanabrava added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17626">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17626#inline-97675">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maindlg.cpp:703-704</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">prt</span><span class="p">.</span><span class="n">setResolution</span><span class="p">(</span> <span style="color: #601200">72</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">QPrintPreviewDialog</span><span style="color: #aa2211">></span> <span class="n">preview</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QPrintPreviewDialog</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">prt</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">KPrinterDlg</span><span style="color: #aa2211">></span> <span class="n">printdlg</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KPrinterDlg</span><span class="p">(</span> <span class="n">m_parent</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">QToolBar</span> <span style="color: #aa2211">*></span> <span class="n">toolbarlist</span> <span style="color: #aa2211">=</span> <span class="n">preview</span><span style="color: #aa2211">-></span><span class="n">findChildren</span><span style="color: #aa2211"><</span><span class="n">QToolBar</span> <span style="color: #aa2211">*></span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If you are creating them here to delete them in the end of the function, why don't you create them on the stack?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17626#inline-97676">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maindlg.cpp:735-736</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span class="n">preview</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">delete</span> <span class="n">printdlg</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">  <span style="color: #aa4000">delete</span> <span class="n">preview</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">create them on the stack do you don't need to call delete.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17626">https://phabricator.kde.org/D17626</a></div></div><br /><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>tcanabrava, kde-doc-english, kde-edu, skadinna, narvaez, apol<br /></div>