<table><tr><td style="">yurchor created this revision.<br />yurchor added a reviewer: KDE Edu.<br />Herald added a project: KDE Edu.<br />Herald added a subscriber: kde-edu.<br />yurchor requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17559">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>As we already have a Qt5 version of libavogadro (1.92) and Kalzium without kdelibs4support, the ability to compile with -DQT_NO_CAST_FROM_ASCII can be seen as a measure to ensure the sustainability of future versions of Kalzium. Please correct me if I'm wrong. Thanks in advance for your comments.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Compiles, can be run and seems working as expected.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17559">https://phabricator.kde.org/D17559</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>compoundviewer/iowrapper.cpp<br />
compoundviewer/kalziumglwidget.cpp<br />
compoundviewer/kalziumglwidget.h<br />
libscience/element.cpp<br />
libscience/elementparser.cpp<br />
libscience/isotopeparser.cpp<br />
libscience/moleculeparser.cpp<br />
libscience/psetables.cpp<br />
libscience/spectrumparser.cpp<br />
libscience/tests/isotopereadingtest.cpp<br />
libscience/tests/spectrumreadingtests.cpp<br />
libscience/tests/xmlreadingtest.cpp</div></div></div><br /><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>