<table><tr><td style="">croick updated this revision to Diff 46877.<br />croick retitled this revision from "[import] Use QSharedPointer for file filters" to "[import] Fix leaking AbstractFileFilters".<br />croick edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-q2uvenrr6mukpn5/">(Show Details)</a><br />croick added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16663">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">rename currentFilter to m_currentFilter and don't use QSharedPointer at all</li>

</ul></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>of `ImportFileWidget::currentFileFilter()`. The filter now is <span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">stored<br />

in a `QSharedPointer` as a member of ImportFileWidget and reused if<br />

the file type does not change.</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">cached</span><br />

<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);">The change is propagated to options widgets</span><span style="padding: 0 2px; color: #333333; background: rgba(151, 234, 151, .6);">as a member of ImportFileWidget and reused if the file type does not change</span>.<div style="padding: 8px 0;">...</div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D16663?vs=46698&id=46877">https://phabricator.kde.org/D16663?vs=46698&id=46877</a></div></div><br /><div><strong>BRANCH</strong><div><div>filterpointer</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16663">https://phabricator.kde.org/D16663</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/backend/datasources/LiveDataSource.cpp<br />

src/backend/datasources/MQTTClient.cpp<br />

src/backend/datasources/MQTTClient.h<br />

src/backend/datasources/MQTTTopic.cpp<br />

src/backend/datasources/MQTTTopic.h<br />

src/backend/datasources/filters/AbstractFileFilter.h<br />

src/backend/datasources/filters/AsciiFilter.cpp<br />

src/backend/datasources/filters/AsciiFilter.h<br />

src/backend/datasources/filters/BinaryFilter.cpp<br />

src/backend/datasources/filters/FITSFilter.cpp<br />

src/backend/datasources/filters/HDF5Filter.cpp<br />

src/backend/datasources/filters/ImageFilter.cpp<br />

src/backend/datasources/filters/JsonFilter.cpp<br />

src/backend/datasources/filters/NetCDFFilter.cpp<br />

src/backend/datasources/filters/NgspiceRawAsciiFilter.cpp<br />

src/backend/datasources/filters/NgspiceRawBinaryFilter.cpp<br />

src/backend/datasources/filters/ROOTFilter.cpp<br />

src/kdefrontend/datasources/FITSOptionsWidget.cpp<br />

src/kdefrontend/datasources/HDF5OptionsWidget.cpp<br />

src/kdefrontend/datasources/ImportFileDialog.cpp<br />

src/kdefrontend/datasources/ImportFileWidget.cpp<br />

src/kdefrontend/datasources/ImportFileWidget.h<br />

src/kdefrontend/datasources/NetCDFOptionsWidget.cpp<br />

src/kdefrontend/datasources/ROOTOptionsWidget.cpp</div></div></div><br /><div><strong>To: </strong>croick, LabPlot, asemke<br /><strong>Cc: </strong>asemke, kde-edu, narvaez, apol<br /></div>