<table><tr><td style="">jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17240">View Revision</a></tr></table><br /><div><div><p>Thank you for the PR, I did some comments</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94251">View Inline</a><span style="color: #4b4d51; font-weight: bold;">PaintCursor.qml:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/* GCompris - PaintItem.qml</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> *</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">update the filename</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94252">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Simplepaint.qml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Keys.onUpPressed:</span><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the coding rules incites to add a space before the {<br />
In the if condition too (if(true) { ... )</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94253">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Simplepaint.qml:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">--</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">current_color</span><span style="color: #aa2211"><</span><span style="color: #601200">0</span><span class="p">){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">current_color</span><span style="color: #aa2211">=</span><span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">colors</span><span class="p">.</span><span style="color: #004012">length</span><span style="color: #aa2211">-</span><span style="color: #601200">1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">can you add spaces before and after '='?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94254">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Simplepaint.qml:99</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">function</span> <span style="color: #004012">changeTab</span><span class="p">(){</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">isColorTab</span><span style="color: #aa2211">=</span><span style="color: #004012">isColorTab</span><span style="color: #aa2211">?</span><span style="color: #aa4000">false:</span><span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #004012">isColorTab</span><span class="p">){</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">isColorTab = !isColorTab</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94202">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Simplepaint.qml:146</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">property</span> <span style="color: #aa4000">var</span> <span style="color: #aa4000">colors:</span> <span style="color: #004012">bar</span><span class="p">.</span><span style="color: #004012">level</span> <span style="color: #aa2211"><</span> <span style="color: #601200">10</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Activity.colorsSimple :</span> <span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">colorsAdvanced</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">property</span> <span class="bright"></span><span style="color: #004012"><span class="bright">string</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">colorSelector:</span></span><span class="bright"> </span><span style="color: #004012">color<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">]</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">var</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">current_</span>color<span class="bright">:</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">string</span> <span style="color: #aa4000">colorSelector:</span> <span style="color: #004012">colors</span><span class="p">[</span><span style="color: #004012">current_color</span><span class="p">]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use an "int" if you already know the type. var is slower</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17240#inline-94255">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Simplepaint.qml:349</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">onReloadClicked:</span> <span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">initLevel</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span style="color: #aa4000"><span class="bright">onPreviousLevelClicked:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Activity</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">previousLevel</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">onReloadClicked:</span> <span class="bright"></span><span class="p"><span class="bright">{</span></span><span style="color: #004012">Activity</span><span class="p">.</span><span style="color: #004012">initLevel</span><span class="p">()<span class="bright">;</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">background</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">refreshCursor</span></span><span class="bright"></span><span class="p"><span class="bright">()}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think you can directly put the background.refreshCursor() in the initLevel().<br />
In this case, you don't need to call it on onPreviousLevelClicked and onNextLevelClicked as they call the initLevel()</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17240">https://phabricator.kde.org/D17240</a></div></div><br /><div><strong>To: </strong>jjazeix, GCompris: Improvements<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>